-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] acount_move_tags: add module #1809
base: 17.0
Are you sure you want to change the base?
[17.0][ADD] acount_move_tags: add module #1809
Conversation
LGTM @OCA/accounting-maintainers can you review? |
Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it Please also squash both commits. |
360b15c
to
69fe028
Compare
Thanks @pedrobaeza for the feedback and explanation! Review of the updated module is much appreciated :) |
"category": "Hidden", | ||
"version": "17.0.1.0.0", | ||
"depends": ["account"], | ||
"license": "LGPL-3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not putting it AGPL-3
for avoiding private extensions on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pedro, we'll dive into the licensing question ;). Thanks
No description provided.