[18.0][MIG] account_invoice_show_currency_rate #1873

JordiMForgeFlow · 2025-01-03T08:04:27Z

Migration to V18:

Odoo adds a new field to display the currency rate on invoices when the currency is different than the company's currency (https://github.com/odoo/odoo/blob/e3d54695862f73d9be6c35121def57ed641a1a45/addons/account/models/account_move.py#L462). However, the computed rate is simply based on the rate configured in the system at the time of computing. It could be the case that a different rate was existing when the invoice was posted, so this module ensures that the rate computed for posted invoices is based on the actual currency amount applied.

Odoo computes the currency rate on journal items (https://github.com/odoo/odoo/blob/e3d54695862f73d9be6c35121def57ed641a1a45/addons/account/models/account_move_line.py#L133). However, the computed rate is based on the rate configured in the system. It could be the case for manually created entries that the user has manually modified the amount in currency, so this module ensures that the computed rate is based on the actual currency amount applied.

…orrect in the main company

…to avoid many decimal places (1.9974358974358974 for example).

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/

Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/es/

Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/it/

… rate

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/it/

…y lines to get rate

…l items

… rate on credit amounts

GuillemCForgeFlow

makes sense to me 👍🏿

AaronHForgeFlow

Functional + code

JasminSForgeFlow

Code review

OCA-git-bot · 2025-01-08T08:13:45Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

victoralmau and others added 30 commits January 2, 2025 15:55

[ADD] account_invoice_show_currency_rate: Show currency rate in invoices

ae5290d

[UPD] Update account_invoice_show_currency_rate.pot

edee607

[UPD] README.rst

4684b6c

[IMP] account_invoice_show_currency_rate: Make sure the currency is c…

19d7ac5

…orrect in the main company

account_invoice_show_currency_rate 13.0.1.0.1

e4ed9a6

[FIX] account_invoice_show_currency_rate: Use assertAlmostEqual in tests

f051f1d

[FIX] account_invoice_show_currency_rate: Round currency_rate_amount …

96d9d42

…to avoid many decimal places (1.9974358974358974 for example).

account_invoice_show_currency_rate 13.0.1.0.2

59aabde

[IMP] account_invoice_show_currency_rate: pre-commit stuff

07d81cd

[MIG] account_invoice_show_currency_rate: Migration to 16.0

3213769

[UPD] Update account_invoice_show_currency_rate.pot

881edd1

[UPD] README.rst

105ebbd

account_invoice_show_currency_rate 16.0.1.0.1

ed83495

[UPD] README.rst

eada210

Added translation using Weblate (Italian)

11740b9

[IMP] account_invoice_show_currency_rate: optional show journal items…

228a83f

… rate

[FIX] account_invoice_show_currency_rate: Use TransactionCase for tests

8dd9be2

[UPD] Update account_invoice_show_currency_rate.pot

65726ce

[BOT] post-merge updates

a733473

[BOT] post-merge updates

3f6d243

[FIX] account_invoice_show_currency_rate: use only debit from currenc…

3064e37

…y lines to get rate

[BOT] post-merge updates

46c7e71

[IMP] : pre-commit auto fixes

5930788

[MIG] account_invoice_show_currency_rate: Migration to 17.0

c0804b2

[IMP] account_invoice_show_currency_rate: add currency rate in journa…

2195ced

…l items

[IMP] account_invoice_show_currency_rate: use absolute balance to get…

2aefe7d

… rate on credit amounts

JordiMForgeFlow force-pushed the 18.0-mig-account_invoice_show_currency_rate branch from ba65629 to ac1d0a9 Compare January 3, 2025 08:15

JordiMForgeFlow marked this pull request as ready for review January 3, 2025 08:20

[MIG] account_invoice_show_currency_rate: Migration to V18

99425ae

JordiMForgeFlow force-pushed the 18.0-mig-account_invoice_show_currency_rate branch from ac1d0a9 to 99425ae Compare January 3, 2025 08:31

GuillemCForgeFlow approved these changes Jan 3, 2025

View reviewed changes

AaronHForgeFlow approved these changes Jan 3, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 3, 2025

JasminSForgeFlow approved these changes Jan 3, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_invoice_show_currency_rate #1873

[18.0][MIG] account_invoice_show_currency_rate #1873

JordiMForgeFlow commented Jan 3, 2025 •

edited

Loading

GuillemCForgeFlow left a comment

AaronHForgeFlow left a comment

JasminSForgeFlow left a comment

OCA-git-bot commented Jan 8, 2025

[18.0][MIG] account_invoice_show_currency_rate #1873

Are you sure you want to change the base?

[18.0][MIG] account_invoice_show_currency_rate #1873

Conversation

JordiMForgeFlow commented Jan 3, 2025 • edited Loading

GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

JasminSForgeFlow left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 8, 2025

JordiMForgeFlow commented Jan 3, 2025 •

edited

Loading