Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] Account Invoice Refund Option #432

Closed

Conversation

ThomasBinsfeld
Copy link
Contributor

Migration of account_invoice_refund_option from 11.0 to 12.0.
#427

Copy link
Contributor

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about code

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

"an invoice",
"version": "12.0.1.0.0",
"category": "Accounting",
"website": "https://www.tecnativa.com/",
Copy link
Member

@nikul-serpentcs nikul-serpentcs Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasBinsfeld Replace URL as per this

"""Add some defaults to let the test run without an accounts chart."""
super(IsRefundCase, cls).setUpClass()
cls.AccountInvoice = cls.env["account.invoice"]
cls.journal_sale = cls.env["account.journal"].create({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasBinsfeld here use central variable for all object

@tafaRU
Copy link
Member

tafaRU commented Oct 4, 2018

@ThomasBinsfeld, please restart Travis build jobs now that branch 12.0 has been created.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 8, 2018
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
30 tasks
@pedrobaeza
Copy link
Member

We discarded this module as Odoo allows to do refund invoices through the 3 dots dropdown.

@emagdalenaC2i
Copy link

@pedrobaeza So, should this PR be closed?

@pedrobaeza
Copy link
Member

I think so.

@pedrobaeza pedrobaeza closed this Jun 4, 2019
@pedrobaeza
Copy link
Member

@ThomasBinsfeld if you still consider it useful, we can keep it.

@ThomasBinsfeld ThomasBinsfeld deleted the 12-mig_account_invoice_refund_option_tbi branch June 4, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants