Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] - support Camt 053 in account_payment_return_import_iso20022 #321

Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

[12.0][IMP] - support Camt 053 in account_payment_return_import_iso20022 #321

wants to merge 1 commit into from

Conversation

sbejaoui
Copy link
Contributor

No description provided.

@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch from 585806d to ed6bf73 Compare March 24, 2020 11:46
sbidoul
sbidoul requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

account_payment_return_import_iso20022/wizard/camt_parser.py Outdated Show resolved Hide resolved
account_payment_return_import_iso20022/wizard/camt_parser.py Outdated Show resolved Hide resolved
account_payment_return_import_iso20022/static/description/index.html Outdated Show resolved Hide resolved
@sbidoul
Copy link
Member

sbidoul commented Mar 24, 2020

@sbejaoui can you add a test file too?

@sbidoul
Copy link
Member

sbidoul commented Mar 24, 2020

Also, I'm mondering why the test files are not under the tests directory.

@sbejaoui
Copy link
Contributor Author

Travis is failing for 12.0 #322

@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch 3 times, most recently from 61bf0d4 to 33d800e Compare March 24, 2020 12:30
@sbejaoui
Copy link
Contributor Author

@sbejaoui can you add a test file too?

done

@sbejaoui sbejaoui requested a review from sbidoul March 24, 2020 12:31
@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch from 33d800e to 5da6f47 Compare March 24, 2020 12:32
sbidoul
sbidoul reviewed Mar 24, 2020
View reviewed changes
account_payment_return_import_iso20022/test_files/test-sepa-camt-054-unpaid.xml
@@ -1,111 +1,111 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file changing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a file name change

account_payment_return_import_iso20022/wizard/camt_parser.py Outdated Show resolved Hide resolved
@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch 8 times, most recently from e3dd57f to 23e9fa9 Compare March 24, 2020 14:23
@sbidoul
Copy link
Member

sbidoul commented Mar 24, 2020

Looks good, thanks!

Last thing, it would be interesting to see what happens when you load a CAMT 053 statement with entries with TxDtls, but no RtrInf.

@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch from 23e9fa9 to c2e5551 Compare March 24, 2020 19:45
@sbejaoui sbejaoui requested a review from sbidoul March 24, 2020 19:45
@sbejaoui
Copy link
Contributor Author

I rebased on #322 to fix unit tests.

@sbejaoui
Copy link
Contributor Author

@sbidoul , can you update your review

@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_import_iso20022-sbj branch from c2e5551 to e7d3c97 Compare May 18, 2020 12:45
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 6, 2022
@github-actions github-actions bot closed this Mar 13, 2022
@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 26, 2023
@sbidoul sbidoul reopened this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul Awaiting requested review from sbidoul

Assignees
No one assigned
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbejaoui @sbidoul