[17.0][MIG] account_payment_widget_amount: Migration to 17.0 #745
Conversation
- adds tests to the python side
Currently translated at 100.0% (4 of 4 strings) Translation: account-payment-12.0/account-payment-12.0-account_payment_widget_amount Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_payment_widget_amount/pt/
Currently translated at 100.0% (4 of 4 strings) Translation: account-payment-15.0/account-payment-15.0-account_payment_widget_amount Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_widget_amount/ca/
Currently translated at 100.0% (4 of 4 strings) Translation: account-payment-15.0/account-payment-15.0-account_payment_widget_amount Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_widget_amount/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: account-payment-16.0/account-payment-16.0-account_payment_widget_amount Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_payment_widget_amount/it/
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
4 times, most recently
from
ac994db to
8432645
Compare
|
@dc-oerp Sorry, I'm not js specialist. Maybe @pedrobaeza |
|
Hi @ChrisOForgeFlow @pedrobaeza Could you please check the pre-commit issue in this PR? Thank you |
|
The error seems clear: you need to fix that. If the JS code is modern style, you need to rename the file to |
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
from
8b3f6d0 to
22dc423
Compare
|
Hi @pedrobaeza I have fixed the js pre-commit issue and I think this is ready to be merged. Thank you |
|
/ocabot migration account_payment_widget_amount Well, now it's OK formally. Then there must be reviews: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review |
|
Hi @pedrobaeza Should I tag somebody to review this? Thank you |
|
Ping the original contributors of the module, and you can review other PRs and ask in exchange that they review yours. |
|
Could you please review this PR? Thank you |
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
2 times, most recently
from
43b8894 to
862f9ba
Compare
|
All comments have been fixed. Thank you |
|
Would you mind reviewing this commit again, all the comments has been fixed. Thanks |
| ) | ||
| invoice.with_context(paid_amount=100.0).js_assign_outstanding_line( | ||
| payment_ml.id | ||
| ) | ||
| self.assertEqual(invoice.amount_residual, 100.0) | ||
| self.assertEqual(invoice.amount_residual, 300.0) |
There was a problem hiding this comment.
Could you explain all the amounts changes ?
There was a problem hiding this comment.
Sorry for the delay,
I have pushed the latest changes to the branch.
The test cases were right, but the code did not give the right result due to some bugs.
I have fixed them all; this should be ready to merge into the production.
Please review again
Thank you
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
3 times, most recently
from
3811e68 to
ce4bbfb
Compare
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
3 times, most recently
from
dcf7e97 to
e19888f
Compare
dc-oerp
force-pushed
the
17.0-mig-account_payment_widget_amount
branch
from
05f4ff8 to
6503d57
Compare
Migrate account_payment_widget_amount module from 16.0 to 17.0