[15.0][FW] account_payment_purchase: multiple ports from 14.0 #1357
Conversation
Steps to reproduce the problem: - Have a partner without payment mode. - Create a PO with such partner. - No payment mode is filled. - Now fill the payment mode in the partner. - Create the invoice for the PO. Current behavior: The invoice has empty payment mode. Expected behavior: The invoice has the partner payment mode. Someone may think that having no payment mode in the PO may prevail over the partner's payment mode, or even their flows may consist in empyting the payment mode in the PO for not binding it with anything yet, but that strategy has more holes than the one implemented here, as the flow presented proves. You can then use another one like having an extra payment mode "Undetermined" or similar for doing such classification as a more resilient strategy. It includes a regression test that fails before the change and now is correct. TT38608
Use company of purchase order when checking the partner. Field supplier_payment_mode_id is company dependant.
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1357-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1357-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4449d96. Thanks a lot for contributing to OCA. ❤️ |
sebalix
deleted the
oca-port-account_payment_purchase-14.0-to-15.0-16ce59
branch
Port of the following PRs from 14.0 to 15.0: