[16.0][MIG] account_statement_import_online_adyen #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NL66278
force-pushed
the
16.0-mig-account_bank_statement_import_online_adyen
branch
14 times, most recently
from
5138cf4 to
7aebbea
Compare
NL66278
changed the title
NL66278
force-pushed
the
16.0-mig-account_bank_statement_import_online_adyen
branch
from
7aebbea to
514284f
Compare
Prevent other statement import modules from processing the file. Without this for instance the Enterprise account_bank_statement_import_csv module will process a retrieved cv file. In addition this is more efficient as it saves a decoding step.
…t_clearing_account
…t_clearing_account
Put more information in the generated statement line. Also put the for users more recognizable merchant ref in the name (Label) field, and put the psp reference in ref. With a small refactoring the information retrieved can also more easily be customized.
Move parsing code to separate class; Break up large and unwieldy parsing method in separate methods.
NL66278
force-pushed
the
16.0-mig-account_bank_statement_import_online_adyen
branch
from
514284f to
7ead4fa
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
ntsirintanis
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some changes to other modules to prevent interference with the workings of this module.
Note that the migrated import of statements has been tested and has extensive user tests, but that the bare minimum has been done for the technical migration of the account_statement_clearing_account module, as I have no extensive knowledge of reconciliation in 16.0.