Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_statement_import_file: Migration to 17.0 #649

Closed

Conversation

rov-adhoc
Copy link

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_file branch 3 times, most recently from dbecb1e to 4e07f3f Compare December 19, 2023 12:30
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_file branch from 4e07f3f to 54c680c Compare December 28, 2023 18:26
@StefanRijnhart
Copy link
Member

@rov-adhoc Please rebase 😃

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_file branch from 54c680c to bb7afbc Compare February 6, 2024 11:18
@rov-adhoc
Copy link
Author

@StefanRijnhart done!!

alexis-via and others added 21 commits March 27, 2024 10:00
The module was renamed from account_statement_import to account_statement_import_file.
The migration has been done from v14 to v16, to take into account the big changes that took place in v14 with the introduction of the module account_statement_import_base. The changes from v15 have been forward-ported to v16.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/hr/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 58.3% (21 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 100.0% (36 of 36 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/ca/
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-account_statement_import_file branch from bb7afbc to 5d17c43 Compare March 27, 2024 13:00
@xtanuiha
Copy link

xtanuiha commented Apr 9, 2024

I have just updated the translation file for Simplified Chinese, could you please merge it into the code? Thank you! @rov-adhoc

zh_CN.zip

@pedrobaeza
Copy link
Member

@xtanuiha please stop publishing that files here. Keep them and you upload them on Weblate once these modules are merged.

@xtanuiha
Copy link

@xtanuiha please stop publishing that files here. Keep them and you upload them on Weblate once these modules are merged.

Excuse me, I just found out that OCA has a Weblate platform for handling translations.

@hbrunn
Copy link
Member

hbrunn commented Apr 22, 2024

/ocabot migration 17.0

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 22, 2024
11 tasks
@pedrobaeza
Copy link
Member

@hbrunn it's /ocabot migration account_statement_import_file

The version is taken from the target branch. What can't be guessed is the module name.

@hbrunn
Copy link
Member

hbrunn commented Apr 22, 2024

@pedrobaeza ah thanks, I keep misremembering ocabot commands. nobump or nopatch and such.

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module never had tests, because testing happens in derived modules like the camt I just added on top of this - should we still add some tests here, mostly checking for error handling?

"only contains already imported transactions."
)
)
self.env["ir.attachment"].create(self._prepare_create_attachment(result))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since v16, there's a many2many field attachment_ids on bank statements, and users would expect to find the file there. So please add this link, would make sense to add it for all created statements I think.

Please do so in a separate commit so that this is easy to cherry pick to v16.

@pedrobaeza
Copy link
Member

Superseded by #692

@pedrobaeza pedrobaeza closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.