-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_statement_import_file: Migration to 17.0 #649
[17.0][MIG] account_statement_import_file: Migration to 17.0 #649
Conversation
dbecb1e
to
4e07f3f
Compare
4e07f3f
to
54c680c
Compare
@rov-adhoc Please rebase 😃 |
54c680c
to
bb7afbc
Compare
@StefanRijnhart done!! |
The module was renamed from account_statement_import to account_statement_import_file. The migration has been done from v14 to v16, to take into account the big changes that took place in v14 with the introduction of the module account_statement_import_base. The changes from v15 have been forward-ported to v16.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/hr/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 58.3% (21 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/pt_BR/
…ue to file_import_oca
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/
Currently translated at 100.0% (36 of 36 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file/ca/
bb7afbc
to
5d17c43
Compare
I have just updated the translation file for Simplified Chinese, could you please merge it into the code? Thank you! @rov-adhoc |
@xtanuiha please stop publishing that files here. Keep them and you upload them on Weblate once these modules are merged. |
Excuse me, I just found out that OCA has a Weblate platform for handling translations. |
/ocabot migration 17.0 |
@hbrunn it's /ocabot migration account_statement_import_file The version is taken from the target branch. What can't be guessed is the module name. |
@pedrobaeza ah thanks, I keep misremembering ocabot commands. nobump or nopatch and such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this module never had tests, because testing happens in derived modules like the camt I just added on top of this - should we still add some tests here, mostly checking for error handling?
"only contains already imported transactions." | ||
) | ||
) | ||
self.env["ir.attachment"].create(self._prepare_create_attachment(result)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since v16, there's a many2many field attachment_ids on bank statements, and users would expect to find the file there. So please add this link, would make sense to add it for all created statements I think.
Please do so in a separate commit so that this is easy to cherry pick to v16.
Superseded by #692 |
Depends on: