[IMP] account_statement_import_camt: multi account support #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurneyalex
force-pushed
the
16.0-import-camt-multi_account
branch
from
204da98 to
8b55347
Compare
The module account_statement_import_file supports handling files containing informations related to multiple accounts, but this was not taken advantage of by account_statement_import_camt. We update the structure returned by parser.parse() to use the expected format in case of multiple accounts encountered in CAMT file. This has the side effect of fixing a bug in the previous implementation, when all the transactions in a CAMT file would be parsed as being on the same account (the one on the last statement found in the file), and possibly even more wrong, in the currency of the last statement).
gurneyalex
force-pushed
the
16.0-import-camt-multi_account
branch
from
6d62744 to
63932d5
Compare
StephaneMangin
approved these changes
Feb 8, 2024
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@gurneyalex any chance of a rebase to resolve conflicts? |
StefanRijnhart
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module account_statement_import_file supports handling files containing informations related to multiple accounts, but this was not taken advantage of by account_statement_import_camt.
We update the structure returned by parser.parse() to use the expected format in case of multiple accounts encountered in CAMT file.
This has the side effect of fixing a bug in the previous implementation, when all the transactions in a CAMT file would be parsed as being on the same account (the one on the last statement found in the file), and possibly even more wrong, in the currency of the last statement).