[16.0][IMP] account_statement_import_online_gocardless: prefer valueDate over bookingDate #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes behavior when there are debit card transactions with bookingDate behind the actual valueDate. In current situation this leads to a situation where these are later discarded in here:
bank-statement-import/account_statement_import_online/models/online_bank_statement_provider.py
Lines 345 to 351 in e91e281
Here's a screenshot of such situation.