[17.0][MIG] account_statement_import_online_gocardless #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration account_statement_import_online_gocardless |
luisDIXMIT
reviewed
Jan 8, 2025
There was a problem hiding this comment.
I get the following error when i try to type into gocardless selection wizard.
TypeError: institutions.filter is not a function at GocardlessDialog.get_institutions (http://oca-bank-statement-import-17-0-pr751-2b072a4706f9.runboat.odoo-community.org/web/assets/2aef316/web.assets_web.min.js:15458:114) at GocardlessDialog.onInstitutionSearch (http://oca-bank-statement-import-17-0-pr751-2b072a4706f9.runboat.odoo-community.org/web/assets/2aef316/web.assets_web.min.js:15457:130) at Object.mainEventHandler (http://oca-bank-statement-import-17-0-pr751-2b072a4706f9.runboat.odoo-community.org/web/assets/2aef316/web.assets_web.min.js:1567:77) at HTMLInputElement.listener (http://oca-bank-statement-import-17-0-pr751-2b072a4706f9.runboat.odoo-community.org/web/assets/2aef316/web.assets_web.min.js:726:15)
What am I doing wrong?
|
Do you have a company selected? |
|
Well, the problem might be that you don't have the API keys |
|
Everything seems correct. One little detail about the button not being showed nicely:
|
This module provides online bank statements from GoCardless Bank Account Data, which provides a free API for connecting and getting transactions for bank accounts. TT45760 Co-Authored-By: Christopher Ormaza <[email protected]> Co-Authored-By: Jordi Ballester <[email protected]>
Not all banks provide an entry reference or transaction ID, so we need to fallback to the Gocardless internal ID for getting the unique ID in such cases. TT46640
… company If the bank account is shared across multiple companies (no assigned company_id), we can't launch the "Select Bank Account Identifier" wizard, so we fallback to the journal company for getting the country. TT43849
Not sure why it didn't raise before.
…xtraction Since one week ago, banks like Sabadell is sending the information in the JSON list `remittanceInformationUnstructuredArray` instead of `remittanceInformationUnstructured`. Thus, we need to parse both for finding the proper element. For the rest that are using the previous one, there's no change. TT47491
…rom other provider Check if there's another provider already linked for the same bank institution, and if so, reuse it for this bank account, as some banks don't allow several requisitions from the same source (GoCardless). TT47944
It turns out that the timeout is for receiving whole answer, so in real tests, the previous timeout was not enough for getting the answer when there are some transactions load (like a month). Let's increase this timeout then to a reasonable amount.
Currently translated at 26.0% (6 of 23 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/es/
Currently translated at 100.0% (23 of 23 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/es/
Currently translated at 100.0% (23 of 23 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/es/
Currently translated at 100.0% (23 of 23 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/es/
… if reusing or not credentials Some banks only allow one credentials, while others work better with separate ones, so it's a matter of trying. This commit introduces a wizard for choosing one method or the other. TT48828
It is possible that, when making the request to the requisitions endpoint, the IBAN bank account comes with a lower alphanumeric string. When comparing with the sanitized bank account (stored with upper) fails. self.journal_id.bank_account_id.sanitized_acc_number == account_data["iban"] to self.journal_id.bank_account_id.sanitized_acc_number == account_data["iban"].upper() Refactor method _gocardless_finish_requisition to be able to mock the requests made inside and create a unit test. Refactor requests methods.
…ctoring After the refactoring in OCA#686, this doesn't work anymore: - The API URL didn't end in "/", so the join_url doesn't do correctly the join. - There's an infinite loop when getting the headers for getting the token.
…asic auth If not, there's a loop.
Some of the API endpoints need it, like token renew. You get if not 405 HTTP code. It includes also a typo fix in a method name.
Currently translated at 100.0% (38 of 38 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/it/
Currently translated at 100.0% (38 of 38 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_gocardless Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_gocardless/it/
… error in wizard new_link method
etobella
force-pushed
the
17.0-gocardless
branch
from
60de928 to
87e4c84
Compare
|
@pedrobaeza Should be fxed now. |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ae4e85a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of JS