-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] account_statement_import_online: add option to enable or disable statement creation. #754
[16.0][IMP] account_statement_import_online: add option to enable or disable statement creation. #754
Conversation
Hi @alexey-pelykh, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. For avoiding too much diff being the same, what you can do is:
if not self.create_statement:
return self._online_create_statement_lines(statement_values)
extracting the specific code of lines there, and leave the rest untouched.
4043870
to
0dfe579
Compare
Thanks for your suggestion! I have applied it as you recommended. Could you please update your review? |
I think you should return the empty statement in the new method. |
0dfe579
to
5ac88ac
Compare
Done |
account_statement_import_online/models/online_bank_statement_provider.py
Outdated
Show resolved
Hide resolved
account_statement_import_online/models/online_bank_statement_provider.py
Show resolved
Hide resolved
account_statement_import_online/models/online_bank_statement_provider.py
Outdated
Show resolved
Hide resolved
5ac88ac
to
74bb842
Compare
account_statement_import_online/models/online_bank_statement_provider.py
Outdated
Show resolved
Hide resolved
…e statement creation. Starting from Odoo 16, bank statements are optional. This commit introduces the option to create statements automatically or skip their creation.
74bb842
to
44cf0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 05a0eb6. Thanks a lot for contributing to OCA. ❤️ |
Starting from Odoo 16, bank statements are optional. This commit introduces the option to create statements automatically or skip their creation.
TT52481
@Tecnativa @pedrobaeza Could you please review this