[16.0][FIX] account_statement_import_sheet_file: Prevent negative index in parser header #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parser header When importing an Excel file with a header and the field header_lines_skip_count is set to its default value (0), the header is retrieved using the -1 index (the last row). complementary to commit OCA@13285ab
|
Hi @alexey-pelykh, |
…tune the UI Before this commit, the parse_header function was unused. It is now utilized to reduce redundant code and improve maintainability. Additionally, UI adjustments have been made for better usability and clarity.
carlos-lopez-tecnativa
force-pushed
the
16.0-fix-account_statement_import_sheet_file-index
branch
from
f2a1aee to
6deab7c
Compare
pedrobaeza
approved these changes
Jan 13, 2025
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f176a7b. Thanks a lot for contributing to OCA. ❤️ |
carlos-lopez-tecnativa
deleted the
16.0-fix-account_statement_import_sheet_file-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing an Excel file with a header and the field
header_lines_skip_countis set to its default value (0), the header is retrieved using the -1 index (the last row).complementary to commit 13285ab
UI Before
UI After
TT52618
@Tecnativa @pedrobaeza @victoralmau @zaoral could you please review this