Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_brand #200

Merged
merged 50 commits into from
Jan 2, 2025
Merged

[17.0][MIG] sale_brand #200

merged 50 commits into from
Jan 2, 2025

Conversation

JasminSForgeFlow
Copy link

@JasminSForgeFlow JasminSForgeFlow commented May 20, 2024 •
edited
Loading

Standard Migration

@ForgeFlow

Depends on:

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@github-actions github-actions bot closed this Oct 27, 2024
@MateuGForgeFlow
Copy link

Hi @max3903 or @sbejaoui,

Can we please reopen this?

Thank you!

@max3903 max3903 reopened this Dec 4, 2024
@max3903 max3903 added this to the 17.0 milestone Dec 4, 2024
@max3903 max3903 added needs review migration no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 4, 2024
@sbejaoui
Copy link
Contributor

sbejaoui commented Jan 1, 2025

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@sbejaoui The rebase process failed, because command git push --force ForgeFlow tmp-pr-200:17.0-mig-sale_brand failed with output:

remote: Permission to ForgeFlow/brand.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/brand/': The requested URL returned error: 403

@sbejaoui
Copy link
Contributor

sbejaoui commented Jan 1, 2025

@JasminSForgeFlow , can you rebase please

sbejaoui
sbejaoui approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

can you rebase please

osi-scampbell and others added 16 commits January 2, 2025 09:25
@osi-scampbell @JasminSForgeFlow
[ADD] sale_brand
6076c5c
@max3903 @JasminSForgeFlow
[DEL] sale_brand: More report to partner_brand
7c3abe3
@sbejaoui @JasminSForgeFlow
[12.0][IMP] - dedicated model for partner model in sale_brand module
1df2160
@zeroheure @JasminSForgeFlow
Fix URL
ec1a105 
was on OCA/partner-contact, switch to OCA/brand
@sbejaoui @JasminSForgeFlow
[12.0][REF] - Use brand mixin in branded sale orders definition
ff0b34e
@OCA-git-bot @JasminSForgeFlow
sale_brand 12.0.2.1.0
3344f0b
@sbejaoui @JasminSForgeFlow
[FIX] - set brand for down payment invoices
9b5ad3f
@sbejaoui @JasminSForgeFlow
[ADD] - Add unit tests
f671d47
@OCA-git-bot @JasminSForgeFlow
sale_brand 12.0.2.1.1
5497bb4
@sbejaoui @JasminSForgeFlow
[12.0][IMP] - Brand field is editable in draft state for invoice and …
976bd94 
…sale object
@OCA-git-bot @JasminSForgeFlow
sale_brand 12.0.3.0.0
96c8e0b
@cubells @JasminSForgeFlow
[IMP] sale_brand: black, isort, prettier
a93df9f
@cubells @JasminSForgeFlow
[MIG] sale_brand: Migration to 13.0
b399c20
@sbejaoui @JasminSForgeFlow
[IMP] - set the sale order analytic account at brand change
52f37b9
@sbejaoui @JasminSForgeFlow
[FIX] - brand field in sale order form view is editable only at draft…
b4a4d4a 
… state
@sbejaoui @JasminSForgeFlow
[IMP] - Add unit tests
670f1d9
ibuioli and others added 17 commits January 2, 2025 09:25
@ibuioli @JasminSForgeFlow
Translated using Weblate (Spanish (Argentina))
a8ff1ac 
Currently translated at 100.0% (7 of 7 strings)

Translation: brand-15.0/brand-15.0-sale_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-15-0/brand-15-0-sale_brand/es_AR/
@sbejaoui @JasminSForgeFlow
[16.0][MIG] - sale_brand migration to 16.0
87199e9
@JasminSForgeFlow
[UPD] Update sale_brand.pot
2713b0b
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
a9bf5d0
@adrienpeiffer @JasminSForgeFlow
sale_brand: fix issue on invoice creation with required brand
c7aa73d
@jdoutreloux @JasminSForgeFlow
[IMP] sale_brand: remove wizard
edcfdf7 
The override of the wizard is now longer necessary with the new version of odoo
@JasminSForgeFlow
[UPD] Update sale_brand.pot
4d15cb0
@OCA-git-bot @JasminSForgeFlow
sale_brand 16.0.1.0.1
924c9f8
@oca-transbot @JasminSForgeFlow
Update translation files
681d3b5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-sale_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-sale_brand/
@JasminSForgeFlow
[UPD] Update sale_brand.pot
e8b417a
@badbole @JasminSForgeFlow
Translated using Weblate (Croatian)
821243a 
Currently translated at 100.0% (6 of 6 strings)

Translation: brand-16.0/brand-16.0-sale_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-sale_brand/hr/
@francesco-ooops @JasminSForgeFlow
Translated using Weblate (Italian)
57170aa 
Currently translated at 100.0% (6 of 6 strings)

Translation: brand-16.0/brand-16.0-sale_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-sale_brand/it/
@Ivorra78 @JasminSForgeFlow
Added translation using Weblate (Spanish)
f7be923
@Ivorra78 @JasminSForgeFlow
Translated using Weblate (Spanish)
651c514 
Currently translated at 100.0% (6 of 6 strings)

Translation: brand-16.0/brand-16.0-sale_brand
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-sale_brand/es/
@OCA-git-bot @JasminSForgeFlow
[UPD] README.rst
ff1cb0d
@JasminSForgeFlow
[IMP] sale_brand: black, isort, prettier
acac74d
@JasminSForgeFlow
[MIG] sale_brand: Migration to 17.0
91201d9
@JasminSForgeFlow
Copy link
Author

LGTM, code review

can you rebase please

Rebased, Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbejaoui
Copy link
Contributor

sbejaoui commented Jan 2, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-200-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0dee0cf into OCA:17.0 Jan 2, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5c9bbb1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateuGForgeFlow MateuGForgeFlow MateuGForgeFlow approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.