Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][12.0]sale_commission: fix internal error trying to print int using %s #442

Closed
wants to merge 1 commit into from

Conversation

odooNextev
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

Copy link

github-actions bot commented Dec 3, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 3, 2023
@odooNextev
Copy link
Author

@pedrobaeza Could you please check this simple fix? Thanks

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 4, 2023
@pedrobaeza
Copy link
Member

But why is this needed? This was working on my side, converting the int to string by Python itself.

@odooNextev
Copy link
Author

On my side I had this error before this fix. Maybe it is because I was working with python 3.6.
/odoo/lib/python3.6/site-packages/odoo/addons/sale_commission/models/sale_commission_mixin.py", line 67, in _compute_commission_status
) % len(line.agents)
TypeError: not all arguments converted during string formatting

@pedrobaeza
Copy link
Member

Maybe it's a question of translations? Are you using it in English or any other language?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 10, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions bot closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants