[13.0] [MIG] agreement -> base_contract #397

i-vyshnevska · 2019-10-16T15:12:44Z

migrate agreement

@bealdav

requested by @bealdav

[UPD] README.rst

Currently translated at 100.0% (27 of 27 strings) Translation: contract-12.0/contract-12.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement/pt_PT/

we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)

max3903 · 2019-10-16T15:14:21Z

@i-vyshnevska Please have a look at #386

gurneyalex · 2019-10-22T09:16:52Z

@i-vyshnevska can you rename the module base_contract?

pedrobaeza · 2019-10-29T08:22:16Z

Do we finally have an agreement - hehe - on the renaming?

sbejaoui

Please consider the discussion about 13.0 road-map #386

jgrandguillaume

Work well on functional side

guewen · 2020-05-06T13:47:57Z

base_contract/models/agreement.py

+    company_id = fields.Many2one(
+        "res.company",
+        string="Company",
+        default=lambda self: self.env["res.company"]._company_default_get(),


_company_default_get() should be removed: https://github.com/odoo/odoo/blob/58492733b81073694a7e2f5e790b31983f91df7d/odoo/addons/base/models/res_company.py#L205

It shows a warning at loading of the module.

Suggested change

default=lambda self: self.env["res.company"]._company_default_get(),

default=lambda self: self.env.company.id,

guewen · 2020-05-06T13:49:48Z

base_contract/views/agreement.xml

+                    <field name="agreement_type_id"
+                           groups="agreement.group_use_agreement_type"/>
+                    <field name="is_template" groups="agreement.group_use_agreement_template"/>


Warnings:

2020-05-06 13:44:29,775 115 WARNING odoodb odoo.addons.base.models.ir_ui_view: The group agreement.group_use_agreement_type defined in view agreement.form does not exist! 2020-05-06 13:44:29,776 115 WARNING odoodb odoo.addons.base.models.ir_ui_view: The group agreement.group_use_agreement_template defined in view agreement.form does not exist!

Suggested change

<field name="agreement_type_id"

groups="agreement.group_use_agreement_type"/>

<field name="is_template" groups="agreement.group_use_agreement_template"/>

<field name="agreement_type_id"

groups="base_contract.group_use_agreement_type"/>

<field name="is_template" groups="base_contract.group_use_agreement_template"/>

I didn't check for other places

Replace deprecated _company_default_get() by standard v13 syntax Add domain field Add chatter on agreement object

alexis-via · 2020-05-27T21:43:07Z

I fixed and improved several points in this PR via a PR on @i-vyshnevska 's branch i-vyshnevska#1

tbaden · 2020-06-16T11:09:51Z

What's the progress on this one? Is there still something todo or does it just need some more reviews?

base_contract: Improve your OCA PR

Chabagutor

Tested and installed for prodution purpose.

alexis-via · 2020-11-13T14:32:15Z

This is ready to be merged. @sbejaoui 's comment is one year old and he asks to take into account the roadmap discussion, and it's precisely what has been implemented here. So let's move on and merge.

alexis-via · 2020-11-13T19:56:15Z

There is something I don't understand with "pre-commit run -a" : when I run it on this branch, it doesn't change anything... although Travis complains about black/isort stuff.
If someone with more experience than me on this can sort it out... it's the last thing needed to merge.

rvalyi · 2020-11-13T20:17:21Z

@alexis-via probably you should try to rebase this branch on 13.0 before trying your local precommit.
Because from Travis logs it complains about XML formatting from the Prettier tool. But in this 13-mig-agreement, the precommit configuration .pre-commit-config.yaml (but may bve also some of the other dot files) is not up to date like in the 13 branch, specially this branch version has no such prettier formating instruction that's why it wont even try to run locally. Instead on Travis it looks it's running the 13.0 pre-commit configuration.

compare:
https://github.com/i-vyshnevska/contract/blob/13-mig-agreement/.pre-commit-config.yaml
https://github.com/OCA/contract/blob/13.0/.pre-commit-config.yaml#L24

Is it clearer now?

alexis-via · 2020-11-23T10:30:09Z

A few days ago, I created another PR to replace this one: #578

newtratip · 2021-02-16T04:17:37Z

@i-vyshnevska please close this pr supersede #628

ygol and others added 19 commits October 16, 2019 17:37

[MIG] agreement: Migration to 12.0

fa32c8c

[FIX] PR review's remarks

6f54bb7

Delete .#__manifest__.py

a50437b

[FIX] remove sql constraint for company_id

ee5811e

Update agreement.py

9c51073

[FIX] add back company_id field

d40ac7b

[FIX] flake8 + demo data

bed3d45

[ADD] notebook in agreement form

4bde414

requested by @bealdav

[UPD] manifest with @max3909 remarks

37c85bc

[FIX] flake8

da883da

Update __manifest__.py

cf3a693

FIX details

ff03bdb

[UPD] Update agreement.pot

2ae9743

[UPD] README.rst

[UPD] README.rst

b20d634

FIX security issue

11c6074

[UPD] Update agreement.pot

39898d7

[FIX] Missing newline

d04773d

Translated using Weblate (Portuguese (Portugal))

5297525

Currently translated at 100.0% (27 of 27 strings) Translation: contract-12.0/contract-12.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement/pt_PT/

i-vyshnevska mentioned this pull request Oct 16, 2019

[13.0] [MIG] agreement sale #398

Merged

gurneyalex mentioned this pull request Oct 17, 2019

Migration to version 13.0 #386

Open

20 tasks

Iryna Vyshnevska added 2 commits October 22, 2019 13:27

[13.0][MIG] agreement: migrate + black

61fab03

[IMP] rename agreement to base_contract

9baa5bf

i-vyshnevska force-pushed the 13-mig-agreement branch from 7aeec7c to 9baa5bf Compare October 22, 2019 10:28

i-vyshnevska changed the title ~~[13.0] [MIG] agreement~~ [13.0] [MIG] agreement -> base_contract Oct 22, 2019

TDu approved these changes Oct 29, 2019

View reviewed changes

pedrobaeza added this to the 13.0 milestone Oct 29, 2019

sbejaoui requested changes Oct 29, 2019

View reviewed changes

jgrandguillaume approved these changes Mar 23, 2020

View reviewed changes

guewen reviewed May 6, 2020

View reviewed changes

FIX ir.rule for odoo 13

8510cca

Replace deprecated _company_default_get() by standard v13 syntax Add domain field Add chatter on agreement object

alexis-via mentioned this pull request May 27, 2020

[13.0] MIG agreement_account and agreement_sale #521

Closed

Merge pull request #1 from akretion/13-mig-agreement-improve

693d8b1

base_contract: Improve your OCA PR

alexis-via approved these changes Jun 18, 2020

View reviewed changes

sbejaoui self-requested a review November 6, 2020 20:59

Chabagutor approved these changes Nov 13, 2020

View reviewed changes

sbejaoui approved these changes Nov 13, 2020

View reviewed changes

OCA-git-bot added the approved label Nov 13, 2020

alexis-via mentioned this pull request Nov 19, 2020

[13.0] MIG base_contract #578

Closed

sergio-teruel mentioned this pull request Feb 3, 2021

[14.0][MIG] agreement #621

Merged

pedrobaeza closed this Feb 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0] [MIG] agreement -> base_contract #397

[13.0] [MIG] agreement -> base_contract #397

i-vyshnevska commented Oct 16, 2019

max3903 commented Oct 16, 2019

gurneyalex commented Oct 22, 2019

pedrobaeza commented Oct 29, 2019

sbejaoui left a comment

jgrandguillaume left a comment

guewen May 6, 2020

guewen May 6, 2020

alexis-via commented May 27, 2020

tbaden commented Jun 16, 2020

Chabagutor left a comment

alexis-via commented Nov 13, 2020

alexis-via commented Nov 13, 2020

rvalyi commented Nov 13, 2020

alexis-via commented Nov 23, 2020

newtratip commented Feb 16, 2021

	default=lambda self: self.env["res.company"]._company_default_get(),
	default=lambda self: self.env.company.id,

[13.0] [MIG] agreement -> base_contract #397

[13.0] [MIG] agreement -> base_contract #397

Conversation

i-vyshnevska commented Oct 16, 2019

max3903 commented Oct 16, 2019

gurneyalex commented Oct 22, 2019

pedrobaeza commented Oct 29, 2019

sbejaoui left a comment

Choose a reason for hiding this comment

jgrandguillaume left a comment

Choose a reason for hiding this comment

guewen May 6, 2020

Choose a reason for hiding this comment

guewen May 6, 2020

Choose a reason for hiding this comment

alexis-via commented May 27, 2020

tbaden commented Jun 16, 2020

Chabagutor left a comment

Choose a reason for hiding this comment

alexis-via commented Nov 13, 2020

alexis-via commented Nov 13, 2020

rvalyi commented Nov 13, 2020

alexis-via commented Nov 23, 2020

newtratip commented Feb 16, 2021