Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] agreement_legal #886

Conversation

davidmonterocrespo24
Copy link

No description provided.

marylla and others added 30 commits January 26, 2022 15:23
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-10.0/contract-10.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-10.0/contract-10.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/fi/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/
Currently translated at 100.0% (15 of 15 strings)

Translation: contract-12.0/contract-12.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/
Currently translated at 100.0% (15 of 15 strings)

Translation: contract-12.0/contract-12.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale_generation/fr/
….order.line

The product UOM qty was not correctly set on the Sale Order Line
During the creation of a recurring Order from a Contract, the given quantity on the Contract Line was not correctly set on the created Sale Order Line.
Use the generation_type field defined now in contract base module.

Improve tests
Currently translated at 100.0% (310 of 310 strings)

Translation: contract-14.0/contract-14.0-contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract/es_AR/
Currently translated at 93.8% (291 of 310 strings)

Translation: contract-14.0/contract-14.0-contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract/fr/
Currently translated at 100.0% (35 of 35 strings)

Translation: contract-14.0/contract-14.0-contract_variable_quantity
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_variable_quantity/pt_BR/
Signed-off-by pedrobaeza
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-14.0/contract-14.0-contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract/
@davidmonterocrespo24 davidmonterocrespo24 changed the title [14.0] [MIG] agreement_legal [15.0] [MIG] agreement_legal Oct 22, 2022
@max3903 max3903 added this to the 15.0 milestone Oct 24, 2022
@davidmonterocrespo24
Copy link
Author

@rousseldenis
@max3903
@mvrodriguez
@marylla

Hello, I am interested in contributing to this repository, but I see that my merge request did not pass some tests. Could you help me?
Best regards

David Montero

@max3903
Copy link
Member

max3903 commented Oct 24, 2022

@davidmonterocrespo24 The pre-commit errors are listed here:
https://github.com/OCA/contract/actions/runs/3304920162/jobs/5454664883

and the tests results are here:
https://github.com/OCA/contract/actions/runs/3304920161/jobs/5454664886#step:8:68

Does it help get you going?

@rousseldenis
Copy link
Contributor

@davidmonterocrespo24 @max3903 Since 15.0, agreement repository exists : https://github.com/OCA/agreement

And this module is merged

@davidmonterocrespo24
Copy link
Author

Hello @rousseldenis
I did not know that these modules had been separated from the repository
Thank you
Best regards

@max3903
Copy link
Member

max3903 commented Oct 26, 2022

So I guess the plan to merge agreement with contract failed... #386

@rousseldenis
Copy link
Contributor

So I guess the plan to merge agreement with contract failed... #386

That would not refrain basing some modules on top of others. But nobody has pointed out a need at this time (apart Alexis, but did it on his side)

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 12, 2023
@github-actions github-actions bot closed this Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.