Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][FIX] crm_lead_product: fix indentation .. #472

Closed
wants to merge 2 commits into from
Closed

[IMP][FIX] crm_lead_product: fix indentation .. #472

wants to merge 2 commits into from

Conversation

Rad0van
Copy link
Sponsor

@Rad0van Rad0van commented Jan 21, 2023

.. not to update lead's revenue after each line

@Rad0van Rad0van mentioned this pull request Jan 21, 2023
Closed
flotho
flotho approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy,
LGTM
Thanks

rousseldenis
rousseldenis reviewed Feb 22, 2023
View reviewed changes
crm_lead_product/models/crm_lead.py Outdated
@@ -17,7 +17,7 @@ def _onchange_lead_line_ids(self):
for lead_line in self.lead_line_ids:
if lead_line.planned_revenue != 0:
planned_revenue += lead_line.planned_revenue
self.planned_revenue = planned_revenue
self.planned_revenue = planned_revenue
Copy link
Sponsor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly. One more indentation back @Rad0van 😅

rousseldenis
rousseldenis reviewed Feb 22, 2023
View reviewed changes
crm_lead_product/models/crm_lead.py Outdated
@@ -17,7 +17,7 @@ def _onchange_lead_line_ids(self):
for lead_line in self.lead_line_ids:
if lead_line.planned_revenue != 0:
planned_revenue += lead_line.planned_revenue
self.planned_revenue = planned_revenue
self.planned_revenue = planned_revenue
Copy link
Sponsor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.planned_revenue = planned_revenue
self.planned_revenue = planned_revenue

@rafaelbn
Copy link
Member

rafaelbn commented Mar 9, 2023

Hello @Rad0van ! you have to suggestions from @rousseldenis . Could you please attend them please? Thank you! 😄

@rafaelbn rafaelbn added this to the 13.0 milestone Mar 9, 2023
rafaelbn
rafaelbn approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please FIX indentation @Rad0van !

Thanks 👍

@rafaelbn
Copy link
Member

rafaelbn commented Mar 9, 2023

@rousseldenis you final review! All done!

@Rad0van
[IMP][FIX] crm_lead_product: fix indentation ..
d7535c9 
.. not to update lead's revenue after each line
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 9, 2023
@github-actions github-actions bot closed this Aug 13, 2023
@Rad0van
Copy link
Sponsor Author

Rad0van commented Aug 13, 2023

@rafaelbn @flotho @rousseldenis can you guys please merge this as it should be OK to go? Thank you.

@rafaelbn rafaelbn reopened this Aug 13, 2023
@rafaelbn rafaelbn removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 13, 2023
@rafaelbn
Copy link
Member

Could you make an empty commit to chech if runboat awake! ? 😄

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@github-actions github-actions bot closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@flotho flotho flotho approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Rad0van @rafaelbn @OCA-git-bot @flotho @rousseldenis