Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] crm_project_task: Module added to create task from lead/opportunities #507

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Jul 18, 2023

  • Configure default project in CRM > Configuration > Project.
  • In any lead click on the button "Create Task"

Solves #481

MT-3175 @moduon @rafaelbn

@rafaelbn rafaelbn changed the title [15.0][ADD] Module added to create task from lead/opportunities [15.0][ADD] crm_project_task: Module added to create task from lead/opportunities Jul 18, 2023
@rafaelbn rafaelbn added this to the 15.0 milestone Jul 18, 2023
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilioPascual , it is not mandatory that Salesman have access to project, they can create but not see project and all task so, the create should have a sude somewhere

imagen

crm_project_task/readme/CONFIGURE.rst Show resolved Hide resolved
crm_project_task/readme/CONTRIBUTORS.rst Show resolved Hide resolved
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review. The module looks quite good, but here you have a bunch of suggestions. Thanks!

crm_project_task/models/res_company.py Show resolved Hide resolved
crm_project_task/readme/newsfragments/.gitkeep Outdated Show resolved Hide resolved
crm_project_task/security/ir.model.access.csv Outdated Show resolved Hide resolved
crm_project_task/tests/common.py Outdated Show resolved Hide resolved
crm_project_task/tests/test_crm_project_task.py Outdated Show resolved Hide resolved
crm_project_task/wizards/crm_create_task.py Outdated Show resolved Hide resolved
crm_project_task/tests/test_crm_project_task.py Outdated Show resolved Hide resolved
crm_project_task/views/crm_lead.xml Show resolved Hide resolved
crm_project_task/wizards/crm_create_task.py Show resolved Hide resolved
crm_project_task/wizards/crm_create_task.py Show resolved Hide resolved
@EmilioPascual EmilioPascual requested a review from yajo July 19, 2023 15:43
@EmilioPascual EmilioPascual force-pushed the 15.0-crm_lead_task_added branch 2 times, most recently from 5badfc5 to ff7b9e9 Compare July 20, 2023 08:31
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor makeups to the test and we're done.

crm_project_task/tests/test_crm_project_task.py Outdated Show resolved Hide resolved
Comment on lines 65 to 67
self.company.crm_default_project_id = False
self.task_name = "Task Test"
self.task_description = "Line1</br>Line2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

crm_project_task/models/res_company.py Show resolved Hide resolved
@moduon MT-3175

Co-authored-by: Rafael Blasco <[email protected]>
Co-authored-by: Jairo Llopis <[email protected]>
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-507-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8ef7304 into OCA:15.0 Jul 21, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7948e48. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 15.0-crm_lead_task_added branch July 21, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants