-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] crm_project_task: Module added to create task from lead/opportunities #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EmilioPascual , it is not mandatory that Salesman have access to project, they can create but not see project and all task so, the create should have a sude somewhere
0d04394
to
5a0a7dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code & functional review. The module looks quite good, but here you have a bunch of suggestions. Thanks!
5a0a7dd
to
3446307
Compare
5badfc5
to
ff7b9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor makeups to the test and we're done.
self.company.crm_default_project_id = False | ||
self.task_name = "Task Test" | ||
self.task_description = "Line1</br>Line2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
@moduon MT-3175 Co-authored-by: Rafael Blasco <[email protected]> Co-authored-by: Jairo Llopis <[email protected]>
ff7b9e9
to
d7490b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7948e48. Thanks a lot for contributing to OCA. ❤️ |
Solves #481
MT-3175 @moduon @rafaelbn