Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP][crm_project_task] link between lead and task #509

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[15.0][IMP][crm_project_task] link between lead and task #509

merged 1 commit into from
Jul 31, 2023

Conversation

EmilioPascual
Copy link
Contributor

  • Added field lead_id in task.
  • Added field task_ids in lead.
  • Added smart button in lead to show related tasks.

@moduon MT-3175 @rafaelbn

@EmilioPascual EmilioPascual force-pushed the 15.0-added_link_between_lead_and_task-crm_project_task branch from 5b1f238 to 19ac326 Compare July 26, 2023 07:31
@rafaelbn
Copy link
Member

Hello @EmilioPascual , are you going to split in a base module?

@EmilioPascual
Copy link
Contributor Author

I think is better. I'm going to split in other module @rafaelbn.
I close pr

@EmilioPascual EmilioPascual reopened this Jul 28, 2023
@EmilioPascual EmilioPascual force-pushed the 15.0-added_link_between_lead_and_task-crm_project_task branch from 19ac326 to 06ea655 Compare July 28, 2023 12:12
@EmilioPascual EmilioPascual mentioned this pull request Jul 28, 2023
Closed
@EmilioPascual
Copy link
Contributor Author

On second thought, base module is not necessary.
Reopen pr

@rafaelbn rafaelbn changed the title [15.0][ADD] link between lead and task [15.0][IMP][crm_project_tas] link between lead and task Jul 28, 2023
@rafaelbn rafaelbn changed the title [15.0][IMP][crm_project_tas] link between lead and task [15.0][IMP][crm_project_task] link between lead and task Jul 28, 2023
@rafaelbn rafaelbn added this to the 15.0 milestone Jul 28, 2023
@EmilioPascual EmilioPascual force-pushed the 15.0-added_link_between_lead_and_task-crm_project_task branch from 06ea655 to a440e5b Compare July 28, 2023 15:42
rafaelbn
rafaelbn requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilioPascual Great! 😄

Just a small issue

  • If clicking to the task in the chatter work 👍🏼
  • But from the smartbuttons you get an error, see:

imagen

@EmilioPascual
[15.0][ADD] link between lead and task
c06b9e8 
- Added field lead_id in task.
- Added field task_ids in lead.
- Added smart button in lead to show related tasks.
@EmilioPascual EmilioPascual force-pushed the 15.0-added_link_between_lead_and_task-crm_project_task branch from a440e5b to c06b9e8 Compare July 31, 2023 07:19
@EmilioPascual
Copy link
Contributor Author

EmilioPascual commented Jul 31, 2023 •
edited
Loading

@EmilioPascual Great! smile

Just a small issue

  • If clicking to the task in the chatter work 👍🏼
  • But from the smartbuttons you get an error, see:

imagen

Fix

https://www.loom.com/share/6e3ced2225b64cff9ae96f6c26dc61c5?sid=395e3012-be26-4e7f-8922-477312048cab

@rafaelbn try again, please

rafaelbn
rafaelbn approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 👍🏼

fcvalgar
fcvalgar approved these changes Jul 31, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funtional review.

LGTM, thank you @EmilioPascual

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-509-by-rafaelbn-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0367703 into OCA:15.0 Jul 31, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5fa4c28. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcvalgar fcvalgar fcvalgar approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilioPascual @rafaelbn @OCA-git-bot @fcvalgar