Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP][crm_lead_vat] Sync vat between partner and lead #511

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[15.0][IMP][crm_lead_vat] Sync vat between partner and lead #511

merged 1 commit into from
Aug 2, 2023

Conversation

EmilioPascual
Copy link
Contributor

  • Add behavior to sync vat between partner and lead.

@moduon MT-3130 @rafaelbn

@EmilioPascual EmilioPascual changed the title [15.0][ADD] Sync vat between partner and lead [15.0][ADD] crm_lead_vat: sync vat between partner and lead Jul 28, 2023
@EmilioPascual EmilioPascual changed the title [15.0][ADD] crm_lead_vat: sync vat between partner and lead [15.0][ADD][crm_lead_vat] Sync vat between partner and lead Jul 28, 2023
@rafaelbn rafaelbn changed the title [15.0][ADD][crm_lead_vat] Sync vat between partner and lead [15.0][IMP][crm_lead_vat] Sync vat between partner and lead Jul 28, 2023
@rafaelbn rafaelbn added this to the 15.0 milestone Jul 28, 2023
rafaelbn
rafaelbn approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

Tested in runboat! 👍🏼

https://www.loom.com/share/5d87d4dd7dbd4380aed64bfd68070184?sid=9065f0cb-b1cd-45a8-9767-fdb164399506

@rafaelbn
Copy link
Member

Discovered a FIX for propagating the VAT to the commercial partner id

@EmilioPascual @rafaelbn
[15.0][IMP] Sync vat between partner and lead
5155a6f 
- Add behavior to sync vat between partner and lead.

@moduon MT-3130 @rafaelbn

Co-authored-by: Rafael Blasco <[email protected]>
@EmilioPascual EmilioPascual force-pushed the 15.0-sync_vat_between_partner_and_lead-crm_lead_vat branch from 76b0883 to 5155a6f Compare July 31, 2023 06:30
@EmilioPascual
Copy link
Contributor Author

EmilioPascual commented Jul 31, 2023 •
edited
Loading

Discovered a FIX for propagating the VAT to the commercial partner id

Fix it

https://www.loom.com/share/7e93f0bca41f40eba7cf0e0f42864b23?sid=3fd72985-39e2-4be4-bb11-15ce4a4ead84

Try now, please

fcvalgar
fcvalgar approved these changes Jul 31, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @EmilioPascual

@rafaelbn
Copy link
Member

rafaelbn commented Aug 2, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-511-by-rafaelbn-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 2, 2023
@OCA-git-bot
Merge PR #511 into 15.0
f5576b1 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-511-by-rafaelbn-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4ea1adf into OCA:15.0 Aug 2, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2774c04. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcvalgar fcvalgar fcvalgar approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilioPascual @rafaelbn @OCA-git-bot @fcvalgar