Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] crm_location: make computes multi-record aware #516

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[16.0][FIX] crm_location: make computes multi-record aware #516

merged 1 commit into from
Sep 8, 2023

Conversation

hildickethan
Copy link
Member

@hildickethan hildickethan commented Aug 16, 2023 •
edited
Loading

Adapt computes to be multi-record aware to avoid singleton errors when creating leads in batch

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 16, 2023
pedrobaeza
pedrobaeza reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the correct wording would be "multi-record aware compute", not "batch compute", as the computation is not done in a batch way.

crm_location/models/crm_lead.py Outdated Show resolved Hide resolved
@hildickethan hildickethan changed the title [16.0][FIX] crm_location: Batch compute [16.0][FIX] crm_location: make computes multi-record aware Aug 16, 2023
@hildickethan
Copy link
Member Author

And the correct wording would be "multi-record aware compute", not "batch compute", as the computation is not done in a batch way.

reworded and added the filtered

pedrobaeza
pedrobaeza approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ioans73
ioans73 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@ioans73 ioans73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-516-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e9dfa14 into OCA:16.0 Sep 8, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6298533. Thanks a lot for contributing to OCA. ❤️

@hildickethan hildickethan deleted the 16.0-crm_location_fix branch September 11, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioans73 ioans73 ioans73 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hildickethan @pedrobaeza @OCA-git-bot @ioans73 @rafaelbn