Fix permissions issue when clicking phonecalls in crm.lead #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Sep 16, 2024
crm_phonecall/models/crm_lead.py
Outdated
| @@ -25,7 +25,7 @@ def _compute_phonecall_count(self): | |||
|
|
|||
| def button_open_phonecall(self): | |||
| self.ensure_one() | |||
| action = self.env.ref("crm_phonecall.crm_case_categ_phone_incoming0") | |||
| action = self.env.ref("crm_phonecall.crm_case_categ_phone_incoming0").sudo() | |||
There was a problem hiding this comment.
The usual thing to do in these cases is to use _for_xml_id method instead of ir.model.data for reading in one shot without permissions problem the action.
There was a problem hiding this comment.
Thank you for correcting. I pushed a commit with the correction applied.
|
Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.