Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] crm_security_group : crm_team full access for crm_manager #599

Merged

Conversation

quentinDupont
Copy link

@quentinDupont quentinDupont commented Sep 27, 2024

CRM teams (called Sales Teams) permissions access are not fit as usual, it might be a typo ?

At the moment

CRM base user (User : Own documents Only + User : All documents) can fully modified crm_team

With this PR

CRM base user (User : Own documents Only + User : All documents) can read crm_team
CRM manager (Administrator) can fully modified crm_team

What do you think @victoralmau ?

@OCA-git-bot
Copy link
Contributor

Hi @victoralmau,
some modules you are maintaining are being modified, check this out!

Copy link

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with that proposal.
changing configuration is for manager in the Odoo logic.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 27, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-599-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c83ba81 into OCA:16.0 Sep 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ddfcbc4. Thanks a lot for contributing to OCA. ❤️

@quentinDupont quentinDupont deleted the 16.0-FIX-crm_security_group-crm_team-access branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants