Skip to content

Commit

Permalink
[FIX] remove comment and improve readme to talk about the delivery_au…
Browse files Browse the repository at this point in the history
…tomatic_package that may be quite usefull with delivery_roulier
  • Loading branch information
florian-dacosta committed Jun 14, 2023
1 parent 4e4aad8 commit f9a9a7b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 0 additions & 3 deletions delivery_roulier/models/stock_picking.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ def _roulier_generate_labels(self):
lambda ml: ml.qty_done > 0.0 and not ml.result_package_id
)
if move_line_no_pack:
# For automatic package creation, for use cases where we only have one
# pack per picking and we don't want to force the user to use pack
# consider installing delivery_automatic_package OCA module
raise UserError(

Check warning on line 90 in delivery_roulier/models/stock_picking.py

View check run for this annotation

Codecov / codecov/patch

delivery_roulier/models/stock_picking.py#L90

Added line #L90 was not covered by tests
_(
"Some products have no destination package in picking %s, "
Expand Down
2 changes: 2 additions & 0 deletions delivery_roulier/readme/CONFIGURE.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This module needs package in order to work.
To generate the carrier labels on the picking, each products need to be assigned to a destination package. In case you don't want to bother with the use of package because the whole content of the picking usually fit in a unique package, you may consider installing the module delivery_automatic_package from the same repository (delivery-carrier). The package will be assigned automatically when asking the carrier labels.

0 comments on commit f9a9a7b

Please sign in to comment.