[16.0][FIX] delivery_package_fee: call map_tax in fiscal.position properly #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothingguy
force-pushed
the
16.0_fix_delivery_package_fee
branch
from
7b704de to
724200a
Compare
cyrilmanuel
approved these changes
Nov 16, 2023
|
hii @pedrobaeza could you review this PR ? |
|
Merging due to existing reviews: /ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at aa17b67. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
delivery_package_fee/models/sale_order.py", line 55, in _prepare_package_fee_line taxes_ids = self.fiscal_position_id.map_tax( TypeError: map_tax() takes 2 positional arguments but 4 were given
TODO