Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][IMP] delivery_cttexpress: configurable label delay #737

Merged

Conversation

chienandalu
Copy link
Member

fw of #735

When we recod a shipping in the CTT Express backend the label API could not be ready in the moment to retrieve the labels. As CTT Express stated, a little delay would add the needed time for the API to be ready.

cc @Tecnativa TT46443

please review @pedrobaeza @victoralmau

@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 12, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@dreispt
Copy link
Member

dreispt commented May 11, 2024

@chienandalu Can you rebase to fix pre-commit, please?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@chienandalu chienandalu force-pushed the 13.0-fix-delivery_cttexpress-shipping-label branch from 97c5b13 to 59cdf0b Compare May 13, 2024 16:23
@chienandalu
Copy link
Member Author

Done @dreispt

@chienandalu chienandalu force-pushed the 13.0-fix-delivery_cttexpress-shipping-label branch from 59cdf0b to 02a369f Compare May 13, 2024 16:26
When we recod a shipping in the CTT Express backend the label API could
not be ready in the moment to retrieve the labels. As CTT Express
stated, a little delay would add the needed time for the API to be
ready.

TT46443
@chienandalu chienandalu force-pushed the 13.0-fix-delivery_cttexpress-shipping-label branch from 02a369f to e55397f Compare May 13, 2024 16:34
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-737-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 14, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-737-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-737-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 30c2463 into OCA:13.0 May 14, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cbf5ebc. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-fix-delivery_cttexpress-shipping-label branch May 14, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants