Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] delivery_purchase: Change the position of the carrier to the purchase order header #740

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[14.0][FIX] delivery_purchase: Change the position of the carrier to the purchase order header #740

merged 1 commit into from
Dec 13, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Dec 13, 2023 •
edited
Loading

Change the position of the carrier to the purchase order header.

v13:
purchase-order-v13

Before:
purchase-order-antes

After:
purchase-order-ahora

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT45656

@victoralmau
[FIX] delivery_purchase: Change the position of the carrier to the pu…
b06c59b 
…rchase order header

In v13 it already appeared in the header, and in v14 by mistake it had been moved
to the "Other information" tab because that was where the company_id field was
currently located.
The carrier price is now hidden if there is no carrier set (to avoid confusion).

TT45656
@pedrobaeza
Copy link
Member

Sorry, for pickings, it's correct that is not on the header, as this is how it goes also for delivery orders AFAIK.

@victoralmau victoralmau force-pushed the 14.0-imp-delivery_purchase-TT45656 branch from 91bd864 to b06c59b Compare December 13, 2023 08:28
@victoralmau victoralmau changed the title [14.0][FIX] delivery_purchase: Change the position of the carrier to the purchase order and picking header [14.0][FIX] delivery_purchase: Change the position of the carrier to the purchase order header Dec 13, 2023
@victoralmau
Copy link
Member Author

Sorry, for pickings, it's correct that is not on the header, as this is how it goes also for delivery orders AFAIK.

Removed the change of picking.

pedrobaeza
pedrobaeza approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-740-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7ad5889 into OCA:14.0 Dec 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ccc9f6e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-imp-delivery_purchase-TT45656 branch December 13, 2023 12:14
@victoralmau victoralmau mentioned this pull request Dec 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu