Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_order_warehouse_from_delivery_carrier: Migration to 17.0 #875

Merged
merged 4 commits into from
Sep 4, 2024
Merged

[17.0][MIG] sale_order_warehouse_from_delivery_carrier: Migration to 17.0 #875

merged 4 commits into from
Sep 4, 2024

Conversation

sanderlienaerts
Copy link

Changed targeted field in the delivery.carrier form view since the pre-migration field amount now resides in a <div> that is not always visible.

geomer198 and others added 3 commits August 6, 2024 09:17
@geomer198 @sanderlienaerts
[ADD] sale_order_warehouse_from_delivery_carrier: Module added.
09aa3f9 
[UPD] Update sale_order_warehouse_from_delivery_carrier.pot

[BOT] post-merge updates
@mymage @sanderlienaerts
Added translation using Weblate (Italian)
89b3d58 
Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-sale_order_warehouse_from_delivery_carrier
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-sale_order_warehouse_from_delivery_carrier/it/
@sanderlienaerts
[IMP] sale_order_warehouse_from_delivery_carrier: black, isort, prettier
4232654
@sanderlienaerts
Copy link
Author

@geomer198 thank you for creating this module, it is now migrated to 17.0. Could you please do a review?

ByteMeAsap
ByteMeAsap approved these changes Aug 6, 2024
View reviewed changes
Copy link

@ByteMeAsap ByteMeAsap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ByteMeAsap
Copy link

@sanderlienaerts , can you please review the PR - #852

@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-sale_order_warehouse_from_delivery_carrier branch from 49da6db to e0a78b3 Compare August 6, 2024 07:58
@sanderlienaerts sanderlienaerts force-pushed the 17.0-mig-sale_order_warehouse_from_delivery_carrier branch from e0a78b3 to 2082f76 Compare August 6, 2024 08:07
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_order_warehouse_from_delivery_carrier

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 22, 2024
Open
26 tasks
@sanderlienaerts
Copy link
Author

@etobella @pedrobaeza @gurneyalex is it possible to get this one merged? thanks in advance!

@pedrobaeza
Copy link
Member

A PSC/module maintainer should review the PR.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-875-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8549848 into OCA:17.0 Sep 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 99ab019. Thanks a lot for contributing to OCA. ❤️

@sanderlienaerts sanderlienaerts deleted the 17.0-mig-sale_order_warehouse_from_delivery_carrier branch September 9, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@joepsanders joepsanders joepsanders approved these changes

@ByteMeAsap ByteMeAsap ByteMeAsap approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sanderlienaerts @ByteMeAsap @OCA-git-bot @rousseldenis @pedrobaeza @joepsanders @geomer198 @mymage