Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] delivery_package_number: port missing commits from 15 #890

Merged
merged 3 commits into from
Oct 7, 2024
Merged

[16.0][IMP] delivery_package_number: port missing commits from 15 #890

merged 3 commits into from
Oct 7, 2024

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Oct 7, 2024 •
edited
Loading

cc @Tecnativa

Commits from v15:

  • [IMP] delivery_package_number: Make compatible with multi pickings validatio(9e52f09)
  • [IMP] delivery_package_number: Ask only once for the number of packages wizard. (e3b3f87)
  • [FIX] delivery_package_number: download label (c3e3262)

Better port required in PR #788

ping @CarlosRoca13 @carlos-lopez-tecnativa

@sergio-teruel sergio-teruel mentioned this pull request Oct 7, 2024
Closed
chienandalu
chienandalu reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this issue? #795

@pedrobaeza
Copy link
Member

Please include #795

@chienandalu @sergio-teruel
[FIX] delivery_package_number: download label
1274e99 
If we don't return the print action the label won't be downloaded.

TT48759
@sergio-teruel
Copy link
Contributor Author

sergio-teruel commented Oct 7, 2024 •
edited
Loading

New commit added!! (#795)

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 7, 2024
chienandalu
chienandalu approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pedrobaeza
pedrobaeza approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

Please fw-port it to 17

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-890-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8229efc into OCA:16.0 Oct 7, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at afad713. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-IMP-delivery_package_number-port-commits-from-15-new branch October 7, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sergio-teruel @pedrobaeza @OCA-git-bot @chienandalu