[17.0][MIG] website_sale_checkout_skip_payment #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeirivera87
force-pushed
the
17.0-mig-website_sale_checkout_skip_payment
branch
2 times, most recently
from
da1d206
to
1560075
Compare
pedrobaeza
changed the title
|
#939 already migrates this module, but both have red CI |
alexeirivera87
force-pushed
the
17.0-mig-website_sale_checkout_skip_payment
branch
2 times, most recently
from
3fc3566
to
18c5d1e
Compare
|
Hello @pedrobaeza @sergio-teruel I fixed most of the tests, but still one raises when running pre-commit:
It is related to this line:
Can you help me to fix it? regards |
|
Hello @chienandalu Any news? regards |
|
@alexeirivera87 To avoid the pre-commit error you must change the .js file extension to .esm.js. |
| @@ -1,47 +1,26 @@ | |||
| odoo.define("website_sale_checkout_skip_payment.tour", function (require) { | |||
| "use strict"; | |||
| /** @odoo-module */ | |||
There was a problem hiding this comment.
/** @odoo-module **/
alexeirivera87
force-pushed
the
17.0-mig-website_sale_checkout_skip_payment
branch
from
18c5d1e
to
09eca7a
Compare
…ment step in checkout process
OCA Transbot updated translations from Transifex
…ut confirmation step when partner is has skip payment flag
Currently translated at 25.0% (2 of 8 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/it/
Currently translated at 87.5% (7 of 8 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/es/
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_checkout_skip_payment/es/
Currently translated at 33.3% (5 of 15 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/nl/
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/ca/
Currently translated at 100.0% (15 of 15 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_checkout_skip_payment/es/
…ttons With this changes the 'Process Checkout' button change to 'Confirm' when the partner has selected the option skip_website_checkout_payment. Furthermore, the button text 'Confirm Order' has been changed to 'Confirm'. TT29736
… user When the client is a public user we got an error, because the request.session.uid is None and the value of the field checkout_skip_payment is not computed. As we want to compute this field always,the condition is removed to avoid the possible error. TT29736
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/es_AR/
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/es/
VAT is required by website_sale_vat_required module TT44388
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/fr/
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/it/
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/pt_BR/
Currently translated at 100.0% (16 of 16 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_checkout_skip_payment Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_checkout_skip_payment/sv/
When an order is confirmed and goes to the path ‘/shop/confirmation’, the driver method involved is ‘shop_payment_confirmation’ from websitesale. With the migration, the wrong method was involved as it was a portal method and its path is ‘/payment/confirmation’, which has nothing to do with the confirmation of an order. TT50360
alexeirivera87
force-pushed
the
17.0-mig-website_sale_checkout_skip_payment
branch
from
09eca7a
to
768e629
Compare
|
Thanks a lot @pilarvargas-tecnativa regards |
|
Let me know @chienandalu regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.