[16.0][MIG] fieldservice_sale: Migration to version 16.0 #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM orders upon sale order confirmation Added option to install fieldservice_sale module
Added support for selling recurring orders
Travis Typo, wrong model relationship Improved values prepation method for recurring Updated errors on SO smart button for recurring
- Completed field service orders will now update the qty_delivered field on linked SO line
- suggestions from reviewer comments
- This change will allow to create an FSM order for each sales order and link it to the delivery order and invoice
- Combine field service template info from sale order lines and add it to field service order
Consumable and Storable product types were not generating field services
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created. - Delete unused computed field.
Sale order and sale order line shared similar code. This simplifies the logic needed to create FSM orders from a sale order while maintaining the same results
Additions made to tests in migration to 15 (5a3201c) do not make sense. They just call certain methods, but assert nothing after the method call
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es_CL/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
As sales order line link to order is preserved when duplicating a Sales Order, the FSM Order generation when confirming the sales order is wrongly skipped. This commit fix it.
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale/it/
only if order line display_type not in ('line_section', 'line_note')
stefan-tecnativa
force-pushed
the
16.0-mig-fieldservice_sale
branch
from
478c522
to
f9e9234
Compare
chienandalu
approved these changes
Jun 12, 2023
|
Please squash last commit into previous one and use Co-Authored-By sentence at the end of the commit message for including yourself and Alexandre Fayolle |
Co-Authored-By: Alexandre Fayolle, Stefan Ungureanu Dependency on migration of fieldservice_account: OCA#1042 Refactoring and fix view errors Fix view error (obsolete XMLID) Remove obsolete onchange Update unit tests
stefan-tecnativa
force-pushed
the
16.0-mig-fieldservice_sale
branch
from
f9e9234
to
1735f9c
Compare
chienandalu
approved these changes
Jun 13, 2023
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
/ocabot migration fieldservice_sale |
|
The migration issue (#963) has been updated to reference the current pull request. |
|
Congratulations, your PR was merged at 8ce531b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT43608
@pedrobaeza please review!
This PR is a superseed of #1041