Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] fieldservice_account_analytic #1127

Merged
merged 31 commits into from
Nov 15, 2023
Merged

[16.0][MIG] fieldservice_account_analytic #1127

merged 31 commits into from
Nov 15, 2023

Conversation

michelerusti
Copy link

@michelerusti michelerusti commented Nov 2, 2023 •
edited
Loading

Since the the original migration PR has been closed, I'll take it in and complete the migration

for issue #963

brian10048 and others added 30 commits November 2, 2023 14:41
@brian10048 @michelerusti
[IMP] fieldservice_account: Simplify module
f663bb1 
- This change removes most of the invoicing logic from fieldservice_account and puts it into its own module
@hparfr @michelerusti
Clean up customer_id (billing), cost and change link between account_…
5df6e7c 
…invoice* and fsm_order
@hparfr @michelerusti
add missing files
ced1ad5
@brian10048 @michelerusti
[FIX] fieldservice_account: tests and travis
dfca2f5
@brian10048 @michelerusti
[IMP] fieldservice_account: Update maintainers
90fa232
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.2.0.2
5087ec8
@osi-scampbell @michelerusti
[IMP] Analytic Account Company Dependant
bd5a43d
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.2.1.0
988e0bc
@murtuzasaleh @michelerusti
[12.0][IMP] fieldservice
4aeb74c
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.3.0.0
e3c5400
@osi-scampbell @michelerusti
[IMP] Set Default Customer
562e411 
[IMP] Move Method Up

[IMP] api.model + space

[IMP] fsm_parent_id

[FIX] Typo
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.3.1.0
1fbdee5
@osi-scampbell @michelerusti
[DEL] Remove fsm_location_person.py
3e666a2
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.3.2.0
bda7dfe
@osi-scampbell @michelerusti
[IMP] Filter Location/Contact
f9f9981 
[IMP] Remove Unused Import

[IMP] Github Comments

[IMP] Add FSM to Variable
@OCA-git-bot @michelerusti
fieldservice_account_analytic 12.0.3.3.0
797963e
@murtuzasaleh @michelerusti
[WIP][13.0][MIG] Fix Travis
ffe9649
@murtuzasaleh @michelerusti
[IMP] Improved code.
41e1f5c
@Freni-OSI @michelerusti
[14.0][MIG] fieldservice_account_analytic
a1fce19
@tate11 @michelerusti
Added translation using Weblate (Turkish)
e8c6c45
@ibuioli @michelerusti
Translated using Weblate (Spanish (Argentina))
8fdc50b 
Currently translated at 100.0% (25 of 25 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_account_analytic/es_AR/
@tate11 @michelerusti
Translated using Weblate (Turkish)
fa0ff84 
Currently translated at 76.0% (19 of 25 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_account_analytic/tr/
@marcos-mendez @michelerusti
Translated using Weblate (Portuguese (Brazil))
78c515b 
Currently translated at 100.0% (25 of 25 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_account_analytic/pt_BR/
@Freni-OSI @michelerusti
[15.0][FIX] Travis
37ef87f
@Freni-OSI @michelerusti
[15.0][MIG] fieldservice_account_analytic
9f20763
@mymage @michelerusti
Added translation using Weblate (Italian)
c692265
@mymage @michelerusti
Translated using Weblate (Italian)
ae61a65 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_account_analytic/it/
@ibuioli @michelerusti
Translated using Weblate (Spanish (Argentina))
0eb7aa8 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_account_analytic/es_AR/
@douglascstd @michelerusti
Translated using Weblate (Portuguese (Brazil))
592bf17 
Currently translated at 95.2% (20 of 21 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_account_analytic
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_account_analytic/pt_BR/
@michelerusti
[IMP] fieldservice_account_analytic: pre-commit stuff
4312cc0
@michelerusti michelerusti force-pushed the 16.0-mig-fieldservice_account_analytic branch from acd0218 to 6a7e1a8 Compare November 2, 2023 14:47
@michelerusti michelerusti marked this pull request as ready for review November 2, 2023 14:51
This was referenced Nov 2, 2023
Open
Merged
@michelerusti michelerusti force-pushed the 16.0-mig-fieldservice_account_analytic branch from 6a7e1a8 to 1692796 Compare November 13, 2023 14:13
@brian10048 brian10048 added this to the 16.0 milestone Nov 13, 2023
stevech091
stevech091 approved these changes Nov 14, 2023
View reviewed changes
Copy link

@stevech091 stevech091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional test ok

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1127-by-brian10048-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 14, 2023
@OCA-git-bot
Merge PR #1127 into 16.0
9898b4e 
Signed-off-by brian10048
@OCA-git-bot
Copy link
Contributor

@brian10048 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1127-by-brian10048-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1127-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7c54186 into OCA:16.0 Nov 15, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2c5d2c6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@are-agilebg are-agilebg are-agilebg approved these changes

@brian10048 brian10048 brian10048 approved these changes

@stevech091 stevech091 stevech091 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.