[18.0][MIG] fieldservice_sale #1231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration fieldservice_sale |
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM orders upon sale order confirmation Added option to install fieldservice_sale module
Added support for selling recurring orders
Travis Typo, wrong model relationship Improved values prepation method for recurring Updated errors on SO smart button for recurring
- Completed field service orders will now update the qty_delivered field on linked SO line
- suggestions from reviewer comments
- This change will allow to create an FSM order for each sales order and link it to the delivery order and invoice
- Combine field service template info from sale order lines and add it to field service order
Consumable and Storable product types were not generating field services
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/pt_BR/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/pt_BR/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/es/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-16.0/field-service-16.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_sale/sk/
[FIX] fieldservice_sale [FIX] fieldservice_sale
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-17.0/field-service-17.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-17.0/field-service-17.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/it/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-17.0/field-service-17.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/es_AR/
Currently translated at 100.0% (29 of 29 strings) Translation: field-service-17.0/field-service-17.0-fieldservice_sale Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_sale/it/
EdgarRetes
force-pushed
the
18.0-mig-fieldservice_sale
branch
2 times, most recently
from
a011982
to
26e2c63
Compare
|
@brian10048 Do you know how to prevent those warnings? |
brian10048
reviewed
Nov 6, 2024
| fsm = self.env["fsm.order"].search( | ||
| [ | ||
| "|", | ||
| ("sale_id", "=", sale.id), |
There was a problem hiding this comment.
@EdgarRetes I think this line is causing the issue.
I would try this and see if it still works and avoids the warning
Suggested change
| ("sale_id", "=", sale.id), | |
| ("sale_id", "in", sale.ids), |
from odoo/odoo@6b907f9
EdgarRetes
force-pushed
the
18.0-mig-fieldservice_sale
branch
from
16207d8
to
3ff8980
Compare
|
@brian10048 that worked, thanks. Can you check it? |
|
My thoughts for improvement to make this module more cohesive with core Odoo features We could remove the field move the "Field Service Tracking" radio to the "Create on Order" dropdown This would require additional refactoring and migration scripts, but I think it is a good time to make the changes. @max3903 would you guys be willing to work on the changes for this? |
|
What if someone wants to create a task and a FSM order? Same list but additional options? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@max3903