Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] hr_attendance_overtime_hours #175

Open
wants to merge 6 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][ADD] hr_attendance_overtime_hours #175

wants to merge 6 commits into from

Conversation

xaviedoanhduy
Copy link

@xaviedoanhduy xaviedoanhduy commented Aug 9, 2024 •
edited
Loading

The original development of this module has been done by Mint System.
It can be found in: https://github.com/Mint-System/Odoo-Apps-HR/blob/15.0/hr_attendance_overtime_hours
This module has been ported to the OCA with their agreement, cc @janikvonrotz

on this occasion:

  • Improved search for attendances of employee based on resource calendar time zone

@xaviedoanhduy xaviedoanhduy mentioned this pull request Aug 9, 2024
Open
6 tasks
leemannd
leemannd reviewed Aug 12, 2024
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some basic unit tests

@xaviedoanhduy xaviedoanhduy force-pushed the 17.0-mig-hr_attendance_overtime_hours branch from bd7d127 to 7d81a50 Compare August 12, 2024 12:30
@xaviedoanhduy xaviedoanhduy force-pushed the 17.0-mig-hr_attendance_overtime_hours branch from 7d81a50 to f35e095 Compare August 12, 2024 12:32
@xaviedoanhduy
Copy link
Author

Please add some basic unit tests

hello @leemannd, I have been added some basic tests

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santostelmo santostelmo santostelmo approved these changes

@victorvermot victorvermot victorvermot approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@leemannd leemannd Awaiting requested review from leemannd

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xaviedoanhduy @OCA-git-bot @leemannd @cyrilmanuel @victorvermot @santostelmo @janikvonrotz