[16.0] [IMP] l10n_fr_department : Change label of country_department_id to fix warning when installed with hr module #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtment_id, department_id) of res.users() have the same label: Department. [Modules: None and hr]"
|
Hi @legalsylvain, |
myrrkel
changed the title
myrrkel
changed the title
myrrkel
changed the title
There was a problem hiding this comment.
I guess you should also change the pot file.
https://github.com/HodeiBot/l10n-france/blob/16.0/l10n_fr_department/i18n/l10n_fr_department.pot#L52
don't you think ?
legalsylvain
approved these changes
Jul 28, 2023
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Jul 28, 2023
|
Congratulations, your PR was merged at 5192ca2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On odoo.sh when installed with hr module, we have this warning :
"Two fields (country_department_id, department_id) of res.users() have the same label: Department. [Modules: None and hr]"