Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [REM] remove l10n_fr_ecotaxe #553

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

gurneyalex
Copy link
Member

This should not have been merged, the modules are being generalized and moved to https://github.com/OCA/account-fiscal-rule

See #483

@gurneyalex gurneyalex changed the title [16.0] [REM] remove l10n_fr_ecotaxe [17.0] [REM] remove l10n_fr_ecotaxe Jun 5, 2024
@gurneyalex gurneyalex added this to the 17.0 milestone Jun 5, 2024
@gurneyalex
Copy link
Member Author

@sbidoul Is this ok or will it have nasty side effects on pypi / weblate / others ?

Similar question for #552 (same PR on 16.0)

@sbidoul
Copy link
Member

sbidoul commented Jun 6, 2024

@gurneyalex removing modules is fine. They will stay on PyPI though. If we want to discourage folks to install them, we have the option to yank the releases on PyPI.

@sbidoul
Copy link
Member

sbidoul commented Jun 6, 2024

Ping me when it's merged, I'll check weblate as I'm not sure it handles removals.

This should not have been merged, the modules are being generalized and moved
to https://github.com/OCA/account-fiscal-rule

See OCA#483
@gurneyalex gurneyalex merged commit 3c18ac4 into OCA:17.0 Jun 6, 2024
4 of 5 checks passed
@gurneyalex
Copy link
Member Author

@sbidoul both PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants