-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] datev_export_dtvf #118
base: 14.0
Are you sure you want to change the base?
Conversation
64e0270
to
3b13e7d
Compare
e985fe4
to
7103c34
Compare
7103c34
to
2a539b8
Compare
2a539b8
to
d747f30
Compare
@hbrunn I tried testing this but I didn't get an export of the account move lines.
|
d747f30
to
67103b4
Compare
thanks @marylla
|
46ba974
to
16ab0d9
Compare
8e74bff
to
fa59925
Compare
@hbrunn Does it make sense to update the PR from here: This would generate the right settings on "Suppress Automatic" already without demanding this to be configured by a user. In general i also would propose to move the following to a level above in the module datev_export. The datev_export_xml module could use this setting too. It is not implemented yet, but it would make a lot of sense to integrate it in datev_export_xml as well, as we currently we export invoice lines with this accounts with a entry in "Bu-Schlüssel". This leads to warnings in DATEV (no errors), but we could easily prevent these warning if we would suppress the BU Schlüssel export for all invoice lines with these accounts. I we would leave it as is, we only would have benefit from this boolean field in the module datev_export_dtvf. What do you think @fkantelberg ? @hbrunn ? |
sounds good to me |
Moving the flag to |
@fkantelberg @hbrunn Yes the flag will be usefull ("nachor") for the next dev iteration of datev_export_xml. -> Write into BU-Code only if the accout of the line doesn't have activated "Suppress BU-Code" |
@hbrunn Do you have an idea why the runbot is pending ? |
@tv-openbig no idea, reopening the PR helps sometimes |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@hbrunn I guess the problem is in the combination of the move lines in >>> list(exp._get_data_transaction(inv))
[{'Umsatz (ohne Soll/Haben-Kz)': '4000,00',
'Soll/Haben-Kennzeichen': 'S',
'Konto': '8400',
'Gegenkonto (ohne BU-Schlüssel)': '8400',
'BU-Schlüssel': '',
'Buchungstext': 'Discount: 10% Discount - On product with following taxes: ',
'Belegdatum': '3008',
'Belegfeld 1': 'INV/2024/08/0002',
'Belegfeld 2': '[FURN_6741] Large Meeting Table\nConference room table',
'KOST1 - Kostenstelle': False,
'KOST-Datum': '30082024',
'WKZ Umsatz': 'EUR',
'Kurs': '1,000000',
'Basis-Umsatz': '4000,00',
'WKZ Basis-Umsatz': 'EUR'},
{'Umsatz (ohne Soll/Haben-Kz)': '36000,00',
'Soll/Haben-Kennzeichen': 'S',
'Konto': '10001',
'Gegenkonto (ohne BU-Schlüssel)': '8400',
'BU-Schlüssel': '',
'Buchungstext': 'INV/2024/08/0002',
'Belegdatum': '3008',
'Belegfeld 1': 'INV/2024/08/0002',
'Belegfeld 2': '[FURN_6741] Large Meeting Table\nConference room table',
'KOST1 - Kostenstelle': False,
'KOST-Datum': '30082024',
'WKZ Umsatz': 'EUR',
'Kurs': '1,000000',
'Basis-Umsatz': '36000,00',
'WKZ Basis-Umsatz': 'EUR'}] EXTF_Buchungsstapel_20240101.csv Also does the Belegdatum need to be just day + month or would it be feasable to add the year too? |
@hbrunn @fkantelberg Belegdatum should not be changed. It is compatible date for DATEV as DATEV reads the year from first line in the csv. |
Yes ok he BU-Schlüssel isn't set up in my instance but the numbers are still weird and it looks like the discount is subtracted twice. The credit in the first journal item is 40k but in the export it's 36k. A customer isn't able to comprehend what it what because the Buchungstext and Belegfeld 2 are confusing if you if you combine multiple lines. Additional the Gegenkonto isn't visible in Odoo. This is a really easy examples. I got some with still multiple lines were it gets harder and harder to determine which is calculated against which other line. |
@fkantelberg The numbers are not weird. Overall the account receivable amount is 36.000 € (40.000 - 4.000). The income is grouped (subtracted) also 36.000 €. There was obviously no tax in the invoice lines, so everything is fine as only the line 2 is relevant. Line 1 is account against itself so "0,00 €" and the line 2 is totally OK. |
@tv-openbig
I hope this helps otherwise we can switch to a meeting or somehing else.
|
account_number = number | ||
else: | ||
offset_account_number = number | ||
data = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if account_number == offset_account_number:
continue
We checked the data again and the lines we could not validate where bookings between the same accounts. Because nothing changes with these we don't need these lines in the CSV.
No description provided.