Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX]l10n_it_sdi_channel: restore python 3.5 compatibility #3089

Closed
wants to merge 1 commit into from

Conversation

aleuffre
Copy link
Contributor

@aleuffre aleuffre commented Dec 16, 2022

The trailing comma in the arguments of methods such as this one

def _prepare_attachment_in_values(
       self,
       file_name,
       file_content,
       **default_values,
   ):

breaks compatibility with python 3.5. Support for this syntax was added in Python 3.6. It's sufficient to remove the trailing comma after default_values in the 3 methods affected.

@OCA-git-bot
Copy link
Contributor

Hi @sergiocorato,
some modules you are maintaining are being modified, check this out!

@aleuffre aleuffre force-pushed the 12.0-fix-python3.5-comp branch 3 times, most recently from 1621858 to 97bc9ef Compare December 16, 2022 09:52
@aleuffre aleuffre force-pushed the 12.0-fix-python3.5-comp branch from 97bc9ef to 5641b45 Compare December 16, 2022 09:54
@SirTakobi
Copy link
Contributor

Thanks, the CI should have caught that, I have proposed the Python version change in OCA/oca-ci#39, let's see how it goes

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions github-actions bot closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.0 missing issue stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants