-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] l10n_it_pos_fatturapa: Migration to 14.0 #3315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok!
@robyf70 che ne pensi? |
possiamo aggiungere a #1905 ? |
Fatto |
constructor() { | ||
super(...arguments); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non mi pare sia strettamente necessario
@robyf70 quando hai un momento ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il resto LGTM
@api.model | ||
def create_from_ui(self, partner): | ||
if "electronic_invoice_subjected" in partner: | ||
electronic_invoice_subjected = bool( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La get()
non ritorna un bool
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, ritorna un None
constructor() { | ||
super(...arguments); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non necessario
02b7ed3
to
be4b8bb
Compare
@caiuka rebase |
3b1cd83
to
321c236
Compare
Migrazione del modulo dalla v12 alla v14