-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] l10n_it_vat_registries #3564
[MIG] l10n_it_vat_registries #3564
Conversation
Le review funzionali rimangono valide dalla #3080 |
/ocabot migration l10n_it_vat_registries |
/ocabot migration l10n_it_vat_registries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test funzionali OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tafaRU merge? |
Provando a stamapare una liquidazione iva sul runboat ottengo il pdf allegato |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh sì per quello ho fatto quel test 😉 |
per il problema della visualizzazione togli le modifiche collegate al header |
Currently translated at 75.0% (45 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Currently translated at 95.0% (57 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
cd26d44
to
acfa01c
Compare
Ho provato entrambe le stampe (allegate) in runboat e mi sembrano a posto, puoi verificare? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM le stampe dopo le modifiche di @SirAionTech
Grazie
acfa01c
to
12c917e
Compare
Co-authored-by: SirAionTech <[email protected]>
12c917e
to
a2fb57e
Compare
Ho ripulito un po' i commit, visto che ho dovuto ripartire da 0 per capire cosa stesse andando storto in account_vat_period_end_statement e l10n_it_account mi sono preso l'authorship di quel commit. |
per me ok |
good news? |
This PR has the |
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 602dc87. Thanks a lot for contributing to OCA. ❤️ |
@@ -1,5 +1,5 @@ | |||
table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SirAionTech
Ciao, questo CSS interferisce con le classi standard di Odoo tipo table-bordered
, che, dopo aver installato l10n_it_account
perdono i bordi.
Ti ricordi il perché di questo !important
e non sarebbe meglio associarlo ad una classe apposita invece "colpire" tutte le table
indiscriminatamente?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 ricordo che avevo tolto un po' di cose da 9694c33, probabilmente questo l'ho lasciato così perché è un modo per mantenere lo stesso comportamento che c'era in 14.0
.
Concordo che sarebbe meglio usare una classe apposta, anche in 14.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheMule71 c'è già una issue o puoi aprirla?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francesco-ooops
Eh, devo costruire un es. apposta...
Sostituisce #3080.