Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] fixed xml on downpayment invoice #3678

Closed
wants to merge 1 commit into from
Closed

[16.0][FIX] fixed xml on downpayment invoice #3678

wants to merge 1 commit into from

Conversation

Marcoapu
Copy link
Contributor

@Marcoapu Marcoapu commented Oct 23, 2023 •
edited
Loading

@Marcoapu Marcoapu mentioned this pull request Oct 23, 2023
Open
2 tasks
@francesco-ooops francesco-ooops changed the title [FIX] fixed xml on downpayment invoice [16.0][FIX] fixed xml on downpayment invoice Dec 19, 2023
@francesco-ooops francesco-ooops linked an issue Dec 19, 2023 that may be closed by this pull request
[16.0] l10n_it_fatturapa_out: Errore XML Su Fatture Con Anticipo #3670
Open
2 tasks
SirAionTech
SirAionTech requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Puoi schiacciare tutti i commit in uno solo? Nota che il commit risultante dovrebbe seguire https://github.com/OCA/odoo-community.org/blob/8afdb5a5ebfd3314e2fc836c9b9f644468ee044e/website/Contribution/CONTRIBUTING.rst#L1114.

Puoi aggiungere un test? Così si evitano regressioni

@Marcoapu Marcoapu closed this by deleting the head repository Mar 8, 2024
@Marcoapu Marcoapu reopened this Mar 18, 2024
DigitalAutomations
DigitalAutomations approved these changes Jun 11, 2024
View reviewed changes
Copy link

@DigitalAutomations DigitalAutomations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional

francescapenso
francescapenso approved these changes Jun 11, 2024
View reviewed changes
Copy link

@francescapenso francescapenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funzionale

@MaurizioPellegrinet
Copy link

Runboat non disponibile al momento, è possibile testarla?

@primes2h
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@primes2h
Copy link
Contributor

Runboat non disponibile al momento, è possibile testarla?

Runboat pronto per i test. :-)

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jun 12, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale OK

@francesco-ooops
Copy link
Contributor

Grazie della PR! Puoi schiacciare tutti i commit in uno solo? Nota che il commit risultante dovrebbe seguire https://github.com/OCA/odoo-community.org/blob/8afdb5a5ebfd3314e2fc836c9b9f644468ee044e/website/Contribution/CONTRIBUTING.rst#L1114.

Puoi aggiungere un test? Così si evitano regressioni

@Marcoapu puoi verificare queste richieste?

@matteoopenf
Copy link
Contributor

e' possibile un rebase? cosi parte runboat?

@SirAionTech
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@matteoopenf
Copy link
Contributor

/ocabot rebase

grazie Mille

matteoopenf
matteoopenf reviewed Aug 2, 2024
View reviewed changes
l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py
if tax_id.credit == 0.0 and tax_id.debit:
tax_amount = -tax_id.balance
if tax_id.credit and tax_id.debit == 0.0:
tax_amount = abs(tax_id.balance)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manca un caso da gestire se sia credit che debit sono uguali zero, l'esempio sarebbe quello di una fattura a zero, altrimenti ci si trova con tax_amount non valorizzato, aggiungo intanto il caso nella mia pr per 14.0

@matteoopenf
Copy link
Contributor

sto riprovando questa pr, con un cliente che ha problemi con gli anticipi e sembra non funzionare.
Qualcun altro per caso ha fatto dei test?
Sembra che sia l'imposta che l'imponibile importo vengano errati,

@matteoopenf matteoopenf mentioned this pull request Sep 24, 2024
Merged
@francesco-ooops
Copy link
Contributor

Mergiata in #4381

@Marcoapu Marcoapu deleted the 16.0-l10n_it_fatturapa_out branch October 4, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteoopenf matteoopenf matteoopenf left review comments

@SirAionTech SirAionTech SirAionTech requested changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@DigitalAutomations DigitalAutomations DigitalAutomations approved these changes

@francescapenso francescapenso francescapenso approved these changes

Assignees
No one assigned
Labels
16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[16.0] l10n_it_fatturapa_out: Errore XML Su Fatture Con Anticipo
9 participants
@Marcoapu @MaurizioPellegrinet @primes2h @OCA-git-bot @francesco-ooops @matteoopenf @SirAionTech @francescapenso @DigitalAutomations