Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] IMP l10n_it_vat_registries allowing to show full contact address in report #3972

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[16.0] IMP l10n_it_vat_registries allowing to show full contact address in report #3972

merged 1 commit into from
Mar 13, 2024

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Feb 16, 2024

No description provided.

@eLBati eLBati force-pushed the 16.0-show_full_contact_addess branch from db215e8 to b34343f Compare February 16, 2024 15:37
@mrcast
Copy link
Contributor

mrcast commented Feb 20, 2024

@eLBati trying to start ruboat I obtain "503 Service Unavailable". Can you please help me?

@eLBati
Copy link
Member Author

eLBati commented Feb 22, 2024

@eLBati trying to start ruboat I obtain "503 Service Unavailable". Can you please help me?

Non rilevo problemi su http://oca-l10n-italy-16-0-pr3972-b34343f2b336.runboat.odoo-community.org

mrcast
mrcast approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functiona test ok.

andreampiovesana
andreampiovesana approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@eLBati issue?

Borruso
Borruso suggested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie per la PR

l10n_it_vat_registries/report/report_registro_iva.xml Outdated
<div
t-if="show_full_contact_addess"
style="page-break-inside: avoid"
t-esc="move.partner_id.contact_address"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non è più corretto in questo modo?

t-field="move.partner_id" 
t-options='{"widget": "contact", "fields": ["address", "name"], "no_marker": True}'

che ne pensi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se con contact_address si ottiene lo stesso risultato con meno righe, come mai vedi più corretto t-field?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perché si usa in tutti i report e nel caso di inherit se qualcuno vuole impostare la partita iva e facile basta cambiare l'attributo t-options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borruso grazie, modificato

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borruso come non detto, ho di nuovo modificato, per 2 motivi: non andare a capo su troppe righe e permettere una migliore ereditabilità, vedi #4023

@eLBati eLBati force-pushed the 16.0-show_full_contact_addess branch 3 times, most recently from 558afc6 to cb89ffb Compare March 7, 2024 11:49
@eLBati eLBati force-pushed the 16.0-show_full_contact_addess branch from cb89ffb to c6a6936 Compare March 7, 2024 11:50
@eLBati eLBati mentioned this pull request Mar 7, 2024
Merged
Borruso
Borruso approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops francesco-ooops mentioned this pull request Mar 12, 2024
Closed
2 tasks
@francesco-ooops francesco-ooops linked an issue Mar 12, 2024 that may be closed by this pull request
l10n_it_vat_registries - allowing to show full contact address in report #4044
Closed
2 tasks
@eLBati
Copy link
Member Author

eLBati commented Mar 13, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3972-by-eLBati-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e5f00c7 into OCA:16.0 Mar 13, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 63973d0. Thanks a lot for contributing to OCA. ❤️

@toita86 toita86 mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borruso Borruso Borruso approved these changes

@mrcast mrcast mrcast approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Assignees
No one assigned
Labels
16.0 approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

l10n_it_vat_registries - allowing to show full contact address in report
6 participants
@eLBati @mrcast @OCA-git-bot @francesco-ooops @andreampiovesana @Borruso