Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX]assets_management: properly open wizard #4345

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

PicchiSeba
Copy link
Contributor

@PicchiSeba PicchiSeba commented Aug 30, 2024

With this PR, the action is properly fetched, solving access errors for non-admin users

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

Copy link
Contributor

@matteoopenf matteoopenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops
Copy link
Contributor

@SirAionTech che ne pensi?

Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Revisione del codice, per me è ok.

È possibile aggiungere un test? Così si evitano regressioni.

@PicchiSeba
Copy link
Contributor Author

@SirAionTech Ho aggiunto il test richiesto

@PicchiSeba PicchiSeba changed the title [14.0][FIX]asset_management: properly open wizard [14.0][FIX]assets_management: properly open wizard Sep 6, 2024
@PicchiSeba PicchiSeba force-pushed the 14.0-fix-asset-wiz-access-error branch from 859e978 to d0861e5 Compare September 6, 2024 14:00
@PicchiSeba
Copy link
Contributor Author

@SirAionTech , aggiunta la parte mancante del test

Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@francesco-ooops
Copy link
Contributor

@SirAionTech mi dai l'ok per il merge? :)

@PicchiSeba PicchiSeba force-pushed the 14.0-fix-asset-wiz-access-error branch from d0861e5 to 5f8d66e Compare September 10, 2024 08:43
@PicchiSeba PicchiSeba force-pushed the 14.0-fix-asset-wiz-access-error branch from 5f8d66e to 95acfa7 Compare September 10, 2024 09:03
@PicchiSeba
Copy link
Contributor Author

@SirAionTech dovremmo esserci

Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie
/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-4345-by-SirAionTech-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e70d787 into OCA:14.0 Sep 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1bb00f. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-fix-asset-wiz-access-error branch September 10, 2024 10:20
@TheMule71 TheMule71 mentioned this pull request Oct 4, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[asset_management] - diritti di accesso per collegare fattura di acquisto a cespite
8 participants