-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX]assets_management: properly open wizard #4345
[14.0][FIX]assets_management: properly open wizard #4345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SirAionTech che ne pensi? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie della PR!
Revisione del codice, per me è ok.
È possibile aggiungere un test? Così si evitano regressioni.
0baf75b
to
1828745
Compare
@SirAionTech Ho aggiunto il test richiesto |
1828745
to
859e978
Compare
859e978
to
d0861e5
Compare
@SirAionTech , aggiunta la parte mancante del test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
@SirAionTech mi dai l'ok per il merge? :) |
d0861e5
to
5f8d66e
Compare
5f8d66e
to
95acfa7
Compare
@SirAionTech dovremmo esserci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at d1bb00f. Thanks a lot for contributing to OCA. ❤️ |
With this PR, the action is properly fetched, solving access errors for non-admin users