Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Impostare data di chiusura alla conferma della liquidazione IVA #4479

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Dec 3, 2024

Implementa #3524 per 16.0.

Forward port di #3525.
Rispetto all'implementazione della PR linkata:

  • viene usata la "data di blocco per la dichiarazione fiscale" (tax_lock_date) invece della "data di blocco per non consiglieri" (period_lock_date), perché la prima in 12.0 non esisteva;
  • è stata aggiunta la dipendenza da account_lock, la cui funzionalità in 12.0 era inglobata in account la dipendenza da account_lock non è tecnicamente necessaria e il modulo impone vincoli molto restrittivi quindi non ho aggiunto la dipendenza.

Queste differenze si vedono bene confrontando il codice di 12.0 https://github.com/odoo/odoo/blob/c50e82c127082f5202cced4bf30bc166bdb9efca/addons/account/models/company.py#L148-L151 con l'analogo di 16.0 https://github.com/odoo/odoo/blob/17d44d6617baf302bf01e5d0f5c3c32a2c8d5007/addons/account_lock/models/res_company.py#L25-L27

@SirAionTech SirAionTech linked an issue Dec 3, 2024 that may be closed by this pull request
3 tasks
@SirAionTech SirAionTech force-pushed the 16.0-imp-account_vat_period_end_statement-set_lock_date branch from baea481 to 465586e Compare December 3, 2024 14:38
@SirAionTech

This comment was marked as resolved.

@SirAionTech SirAionTech marked this pull request as ready for review December 3, 2024 14:50
@SirAionTech
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-imp-account_vat_period_end_statement-set_lock_date branch from 465586e to 28f0d0c Compare December 9, 2024 09:30
@SirAionTech SirAionTech force-pushed the 16.0-imp-account_vat_period_end_statement-set_lock_date branch from 28f0d0c to 60bc968 Compare December 11, 2024 08:18
@SirAionTech
Copy link
Contributor Author

Fatto rebase per risolvere i conflitti, e rimossa dipendenza da account_lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impostare data di chiusura alla conferma della liquidazione IVA
3 participants