Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] l10n_nl_xaf_auditfile_export: opening balance support #411

Merged
4 commits merged into from
Mar 25, 2024
Merged

[12.0][ADD] l10n_nl_xaf_auditfile_export: opening balance support #411

4 commits merged into from
Mar 25, 2024

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Mar 18, 2024 •
edited
Loading

cherry pick of the opening balance part from #247

Being at it, I also cherry picked the commit from #323 for rounding non-rounded fields.

Fix for l10n_nl_kvk's tests pending.

@hbrunn hbrunn force-pushed the 12.0-l10n_nl_xaf_auditfile_export-opening-balance branch from 147a1ff to 16b4b78 Compare March 19, 2024 19:25
@hbrunn
Copy link
Member Author

hbrunn commented Mar 19, 2024

tests fixed in #412

thomaspaulb and others added 3 commits March 19, 2024 22:28
@thomaspaulb @hbrunn
[ADD] opening balance support
f74c386
@jeroen-vet @hbrunn
Rounded move totals and move line amounts in view as these amounts ar…
352cf71 
…e not rounded in python code so could still occur too many decimals error.
@hbrunn
[IMP] calculate opening debit, credit from balance of opening lines
30dd0e0 
only consider posted move lines for opening balance
@hbrunn hbrunn force-pushed the 12.0-l10n_nl_xaf_auditfile_export-opening-balance branch from 98272e5 to 30dd0e0 Compare March 19, 2024 21:28
StefanRijnhart
StefanRijnhart approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same numbers as on my balance sheet report now. Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-411-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 25, 2024
@OCA-git-bot
Merge PR #411 into 12.0
e360819 
Signed-off-by thomaspaulb
@OCA-git-bot OCA-git-bot closed this pull request by merging all changes into OCA:12.0 in 8bd4719 Mar 25, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8bd4719. Thanks a lot for contributing to OCA. ❤️

@hbrunn hbrunn mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjotten gjotten gjotten left review comments

@thomaspaulb thomaspaulb thomaspaulb approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hbrunn @OCA-git-bot @thomaspaulb @StefanRijnhart @gjotten @jeroen-vet