Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_es_pos: offline simplified number #2582

Closed
wants to merge 1 commit into from
Closed

[14.0][FIX] l10n_es_pos: offline simplified number #2582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions l10n_es_pos/readme/ROADMAP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
No se comprueba el límite en operaciones separadas para un mismo cliente, algo
que Hacienda proscribe.
* No se comprueba el límite en operaciones separadas para un mismo cliente, algo
que Hacienda proscribe.
* El soporte para usuarios concurrentes sobre una misma sesión es limitado y solo es
fiable si ambos puestos están online. En el caso de que cualquiera de ellos estuviese
offline, se correría el riesgo de solapar la secuencia de factura simplificada. Se
recomienda que en estos casos se añada mejor una configuración de punto de venta
adicional.
8 changes: 4 additions & 4 deletions l10n_es_pos/static/src/js/PaymentScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ odoo.define("l10n_es_pos.PaymentScreen", function (require) {

const L10nEsPosPaymentScreen = (PaymentScreen) =>
class extends PaymentScreen {
async validateOrder(isForceValidate) {
var below_limit =
async _finalizeValidation() {
const below_limit =
this.currentOrder.get_total_with_tax() <=
this.env.pos.config.l10n_es_simplified_invoice_limit;
if (this.env.pos.config.iface_l10n_es_simplified_invoice) {
var order = this.currentOrder;
const order = this.currentOrder;
if (below_limit && !order.to_invoice) {
await order.set_simple_inv_number();
} else {
// Force invoice above limit. Online is needed.
order.to_invoice = true;
}
}
super.validateOrder(isForceValidate);
super._finalizeValidation();
}
};

Expand Down
42 changes: 27 additions & 15 deletions l10n_es_pos/static/src/js/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@ odoo.define("l10n_es_pos.models", function (require) {
initialize: function () {
pos_super.initialize.apply(this, arguments);
this.pushed_simple_invoices = [];

this.own_simplified_invoice_prefix = ""; // Unique UUID
return this;
},
get_simple_inv_next_number: function () {
// If we had pending orders to sync we want to avoid getting the next number
// from the DB as we'd be ovelaping the sequence.
if (this.env.pos.db.get_orders().length) {
return Promise.reject({message: {code: "pending_orders"}});
}
return this.rpc({
method: "search_read",
domain: [["id", "=", this.config_id]],
Expand Down Expand Up @@ -70,24 +73,33 @@ odoo.define("l10n_es_pos.models", function (require) {
return total;
},
set_simple_inv_number: function () {
const self = this;
return this.pos
.get_simple_inv_next_number()
.then(function (configs) {
const config = configs[0];
self.pos.config.l10n_es_simplified_invoice_number =
.then(([config]) => {
// We'll get the number from DB only when we're online. Otherwise
// the sequence will run on the client side until the orders are
// synced.
this.pos.config.l10n_es_simplified_invoice_number =
config.l10n_es_simplified_invoice_number;
})
.catch((error) => {
// We'll only consider network errors (XmlHttpRequestError) or
// forced rejections to resync invoice numbers
if (
error.message &&
![-32098, "pending_orders"].includes(error.message.code)
) {
throw error;
}
})
.finally(() => {
const simplified_invoice_number =
self.pos.config.l10n_es_simplified_invoice_prefix +
self.pos.get_padding_simple_inv(
config.l10n_es_simplified_invoice_number
this.pos.config.l10n_es_simplified_invoice_prefix +
this.pos.get_padding_simple_inv(
this.pos.config.l10n_es_simplified_invoice_number
);
self.l10n_es_unique_id = simplified_invoice_number;
self.is_simplified_invoice = true;
})
.catch(function () {
self.l10n_es_unique_id = self.uid;
self.is_simplified_invoice = true;
this.l10n_es_unique_id = simplified_invoice_number;
this.is_simplified_invoice = true;
});
},
get_base_by_tax: function () {
Expand Down