Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_es_aeat_mod216: Migration to 16.0 #2697

Merged
merged 31 commits into from
Jan 6, 2023

Conversation

FernandoRomera
Copy link
Contributor

No description provided.

agaldona and others added 30 commits December 22, 2022 11:14
…lculo por códigos de impuestos generalizado + tratamiento residentes 216 y cálculo, traducciones
…lugar de recordset + gestionar grupos de compañías
…ixes OCA#290

Cuando se tienen campos related, aunque el valor no se cambie,
Odoo lanza una escritura en el objeto relacionado cada vez que se
guarda el objeto principal. En el caso de la moneda asociada a la
compañía, hace que aquellos usuarios que no tengan permiso para
modificar la compañía (la mayoría), falle en la creación del modelo.
El anterior método utilizado, al tener una clase y un many2one genérico,
no permitía poner los datos en múltiples modelos hijos, ya que se repetían
los IDs, y cogía los datos de un modelo en otros.

Con este nuevo sistema, se sigue utilizando una tabla, pero con doble
índice: el modelo y el ID, parecido a un campo reference, pero gestionado
por código propio en el método de cálculo.

El 303 está adaptado a este nuevo sistema, y se incluye un script de
migración que conserve los datos.
* Standard migration procedure
a nivel individualizado, sino agrupadas.
Se corrije el filtro de asientos del mod 111 para que se
tengan en cuenta los apuntes contables asociados a IRPF
para tanto empresas que son residentes como para el caso en que
no se ha informado la empresa en el apunte contable de la nómina.

En caso del modelo 216, sí que parece más justificado tener
que introducir el campo empresa.
This way, we don't initially see all the subconfigs for each model and we can concentrate
on main export configurations. This is got through `active` field default behaviour.
Archived config are still directly searchable through the subconfig selector in the
configuration line.

All models export configs have been adapted to this new approach.
Previous approach was not correct, as the used taxes don't apply to non resident.

We use now l10n_es_irnr module for having proper taxes, map them in the model, and
adapt the rest of the needed things.
* Float > Monetary and remove view definition
* casilla_07 must be monetary (float), not integer
* Include chatter (mail.thread)
* Include activities (mail.activity.mixin)
* Track AEAT report state change
* Include new admin user in AEAT group by default
…n tests

This way, we can reuse it in other modules that don't inherit AEAT report like SII.

We also clean a non needed reading of the tax description field.

Tests were still using description method for populating data, so we switch to new
system and perform needed changes in dependent tests.

s
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_mod216
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_mod216/
@FernandoRomera
Copy link
Contributor Author

#2526

@FernandoRomera
Copy link
Contributor Author

Depend #2698

@FernandoRomera FernandoRomera force-pushed the 16.0-mig-l10n_es_aeat_mod216 branch from 32de640 to 51e7156 Compare December 29, 2022 06:18
@FernandoRomera FernandoRomera force-pushed the 16.0-mig-l10n_es_aeat_mod216 branch from 51e7156 to aa49e9d Compare December 29, 2022 07:26
Copy link

@MRomeera MRomeera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration l10n_es_aeat_mod216

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 6, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 6, 2023
54 tasks
@OCA OCA deleted a comment from OCA-git-bot Jan 6, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2697-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4582b47 into OCA:16.0 Jan 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2b9ffdc. Thanks a lot for contributing to OCA. ❤️

@FernandoRomera FernandoRomera deleted the 16.0-mig-l10n_es_aeat_mod216 branch January 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.