[14.0][ADD] currency_rate_update_nbu #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod "_process_request" to "_nbu_process_request"
| "category": "Accounting & Finance", | ||
| "summary": "Allows to download currency exchange rates from " | ||
| "National Bank of Ukraine", | ||
| "author": "Garazd Creation," "Odoo Community Association (OCA),", |
There was a problem hiding this comment.
" " is not needed here
There was a problem hiding this comment.
As well as coma in ,"
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
There was a problem hiding this comment.
Why do you need this file? Also, I would guess if you do want to auto-create the provider, it needs to be noupdate
alexey-pelykh
requested changes
Oct 13, 2022
alexey-pelykh
changed the title
|
Also, please add the readme components |
|
Thank you, Alexey. I will make changes and commit. |
| return super()._get_supported_currencies() | ||
| # List of currencies obrained from: | ||
| # https://bank.gov.ua/NBUStatService/v1/statdirectory/exchange?json | ||
| return [ |
There was a problem hiding this comment.
do not use hardcoded list, do a dynamic call to nbu service and parse json properly
| :return: dict | ||
| """ | ||
| content = defaultdict(dict) | ||
| url = "https://bank.gov.ua/NBUStatService/v1/statdirectory/exchange?json" |
There was a problem hiding this comment.
make url configurable, suppose "ir.config_parameter" would be good
There was a problem hiding this comment.
Thank you, Iryna, for your propositions. They were implemented.
…er with api url; improve update logic
…er with api url; improve update logic
…tion/oca-l10n-ukraine into 14.0-currency_rate_update_nbu
…rrency" to oca_dependencies.txt
[REF] currency_rate_update_nbu: fix manifest checks result; rename method "_process_request" to "_nbu_process_request" [IMP] currency_rate_update_nbu: add README.rst; add ir.config_parameter with api url; improve update logic [REF] currency_rate_update_nbu: change README.rst [14.0][IMP] currency_rate_update_nbu: add and configure setup [IMP] currency_rate_update_nbu: add README.rst; add ir.config_parameter with api url; improve update logic [FIX] currency_rate_update_nbu: fix pre-commit errors [IMP] oca-l10n-ukraine: add setup.py [FIX] currency_rate_update_nbu: configure setup [14.0][FIX] .pre-commit-config.yaml: change URL to "https://github.com/PyCQA/flake8" [IMP] currency_rate_update_nbu: add files to "readme" folder; add "currency" to oca_dependencies.txt [FIX] currency_rate_update_nbu: fix pylint error E7901(rst-syntax-error) [REF] currency_rate_update_nbu: change param in method "_nbu_get_rate" call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.