Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] eslint luxon global variable #205

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Aug 24, 2023

luxon is available globally so no eslint errors should be thrown when importing from it like in

const {DateTime} = luxon

Example: https://github.com/OCA/web/blob/84ffe96670ecb3c9c6d06b3c4a0bbee83e84d889/web_time_range_menu_custom/static/src/js/date_selector.esm.js#L9

cc @Tecnativa

luxon is available globally so no eslint errors should be thrown when
importing from it like in

```js
const {DateTime} = luxon
```
@yajo yajo merged commit 0b8c45e into OCA:master Sep 6, 2023
7 of 8 checks passed
@chienandalu
Copy link
Member Author

Thanks :)

@pedrobaeza pedrobaeza deleted the add-eslint-global-luxon branch September 6, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants